Skip to content
This repository was archived by the owner on Nov 16, 2021. It is now read-only.

Remove search tasks #232

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Remove search tasks #232

merged 1 commit into from
Dec 20, 2016

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Dec 20, 2016

These tasks are no longer up to date (panopticon doesn't do search anymore).

To avoid confusion it's better to remove the code altogether. We've not used this fabric task in the last year, as far as I know.

@carvil

@tijmenb tijmenb requested a review from carvil December 20, 2016 11:42
Copy link
Contributor

@carvil carvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. As discussed IRL, the remaining rake tasks don't exist in rummager anymore and we shouldn't use fabric for those. Let's delete them in a separate PR.

merge when green 👍

@tijmenb tijmenb force-pushed the remove-search-task branch 2 times, most recently from f0451aa to 52de5e6 Compare December 20, 2016 11:48
@tijmenb tijmenb changed the title Remove search indexing tasks Remove search tasks Dec 20, 2016
@tijmenb
Copy link
Contributor Author

tijmenb commented Dec 20, 2016

Amended the commit to remove all the search tasks.

These tasks are no longer up to date (panopticon doesn't do search
anymore).

To avoid confusion it's better to remove the code altogether. We've not
used these fabric tasks in the last year, as far as I know.
@carvil carvil merged commit 98fc2dd into master Dec 20, 2016
@carvil carvil deleted the remove-search-task branch December 20, 2016 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants