filter sensitive data for vhr request, and verify all TRAVIS tests pass

sirwolfgang · sirwolfgang · commit c777827f67f0 · 2014-07-26T16:35:37.000Z
diff --git a/spec/models/account_spec.rb b/spec/models/account_spec.rb
@@ -56,10 +56,14 @@ def post_job_for(team)
 
       end
     end
-
+    
+    # BUG: This request does not produce the same results out of two calls, under the Account cassette.
+    # 	Something is stomping its request.
+    # 	1st call, under record all will pass this test
+    # 	2nd call, under new or none will fail, returning a previously recorded request
     it 'should not create an account if stripe_card_token invalid' do
       # TODO: Refactor api calls to Sidekiq job
-      VCR.use_cassette("Account") do
+      VCR.use_cassette("Account_Invalid") do
 
         account[:stripe_card_token] = "invalid"
         team.build_account(account)
@@ -124,6 +128,10 @@ def post_job_for(team)
         end
       end
 
+      # BUG: This request does not produce the same results out of two calls.
+      # 	1st call, under record all will pass this test
+      # 	2nd call, under non will fail to match with previously recorded request
+      # 	3rd call, under new will record a worket set of data for this test
       it 'should allow upgrade to monthly subscription' do
         # TODO: Refactor api calls to Sidekiq job
         VCR.use_cassette("Account") do
diff --git a/spec/models/badges/ashcat_spec.rb b/spec/models/badges/ashcat_spec.rb
@@ -3,8 +3,8 @@
   let(:contributor) { Fabricate(:user, github_id: profile.github_id, github: 'dhh') }
 
   it 'creates facts for each contributor' do
-    VCR.use_cassette('ashcat_creates_facts_for_each_contributor') do
-      # TODO: Refactor to utilize sidekiq job
+    # TODO: Refactor to utilize sidekiq job
+    VCR.use_cassette('Ashcat') do
       Ashcat.perform
 
       contributor.build_github_facts
diff --git a/spec/models/github_profile_spec.rb b/spec/models/github_profile_spec.rb
@@ -26,7 +26,7 @@ def response_body(file)
 
   describe 'facts' do
     let (:profile) {
-      VCR.use_cassette('github_profile_for_mdeiters') do
+      VCR.use_cassette('GithubProfile') do
         GithubProfile.for_username('mdeiters')
       end
     }
diff --git a/spec/vcr_helper.rb b/spec/vcr_helper.rb
@@ -7,6 +7,8 @@ def record_mode
     :all
   when 'new'
     :new_episodes
+  when 'once'
+    :once
   else
     :none
   end
@@ -19,5 +21,35 @@ def record_mode
   c.default_cassette_options                = { record: record_mode }
   c.allow_http_connections_when_no_cassette = false
   c.configure_rspec_metadata!
-end
+  
+  # Github
+  c.filter_sensitive_data('<GITHUB_ADMIN_USER_PASSWORD>') { ENV['GITHUB_ADMIN_USER_PASSWORD'] }
+  c.filter_sensitive_data('<GITHUB_CLIENT_ID>')						{ ENV['GITHUB_CLIENT_ID'] }
+  c.filter_sensitive_data('<GITHUB_SECRET>') 							{ ENV['GITHUB_SECRET'] }
+  
+  # LinkedIn
+  c.filter_sensitive_data('<LINKEDIN_KEY>') 							{ ENV['LINKEDIN_KEY'] }
+  c.filter_sensitive_data('<LINKEDIN_SECRET>') 						{ ENV['LINKEDIN_SECRET'] }
+  
+  # Mailgun
+  c.filter_sensitive_data('<MAILGUN_API_KEY>') 						{ ENV['MAILGUN_API_KEY'] }
+  c.filter_sensitive_data('<MAILGUN_TOKEN>') 							{ ENV['MAILGUN_TOKEN'] }
 
+  # Mixpanel
+  c.filter_sensitive_data('<MIXPANEL_API_SECRET>') 				{ ENV['MIXPANEL_API_SECRET'] }
+  c.filter_sensitive_data('<MIXPANEL_TOKEN>') 						{ ENV['MIXPANEL_TOKEN'] }
+  
+  # Twitter
+  c.filter_sensitive_data('<TWITTER_ACCOUNT_ID>') 				{ ENV['TWITTER_ACCOUNT_ID'] }
+  c.filter_sensitive_data('<TWITTER_CONSUMER_KEY>') 			{ ENV['TWITTER_CONSUMER_KEY'] }
+  c.filter_sensitive_data('<TWITTER_CONSUMER_SECRET>') 		{ ENV['TWITTER_CONSUMER_SECRET'] }
+  c.filter_sensitive_data('<TWITTER_OAUTH_SECRET>') 			{ ENV['TWITTER_OAUTH_SECRET'] }
+  c.filter_sensitive_data('<TWITTER_OAUTH_TOKEN>') 				{ ENV['TWITTER_OAUTH_TOKEN'] }
+  
+  # Stripe
+  c.filter_sensitive_data('<STRIPE_PUBLISHABLE_KEY>') 		{ ENV['STRIPE_PUBLISHABLE_KEY'] }
+  c.filter_sensitive_data('<STRIPE_SECRET_KEY>') 					{ ENV['STRIPE_SECRET_KEY'] }
+  
+  # Akismet
+  c.filter_sensitive_data('<AKISMET_KEY>') 								{ ENV['AKISMET_KEY'] }
+end

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ def response_body(file)`
`26`	`26`
`27`	`27`	`describe 'facts' do`
`28`	`28`	`let (:profile) {`
`29`		`- VCR.use_cassette('github_profile_for_mdeiters') do`
	`29`	`+ VCR.use_cassette('GithubProfile') do`
`30`	`30`	`GithubProfile.for_username('mdeiters')`
`31`	`31`	`end`
`32`	`32`	`}`