Moved logic to determine if git command meets required version down into Git::Lib, so other libraries can make use of it.

technicalpickles · technicalpickles · commit 2aca2933def7 · 2009-08-01T18:59:43.000-04:00
diff --git a/lib/git.rb b/lib/git.rb
@@ -26,13 +26,9 @@
 require 'git/stashes'
 require 'git/stash'
 
-minimum_version = [1, 6, 0, 0]
-current_version = Git::Lib.new(nil, nil).command_version
-if current_version[0] < minimum_version[0] || 
-   current_version[1] < minimum_version[1] ||
-   current_version[2] < minimum_version[2] ||
-   current_version[3] < minimum_version[3]
-  $stderr.puts "The git gem requires git #{minimum_version.join('.')} or later, but only found #{current_version.join('.')}. You should probably upgrad.e"
+lib = Git::Lib.new(nil, nil)
+unless lib.meets_required_version?
+  $stderr.puts "[WARNING] The git gem requires git #{lib.required_command_version.join('.')} or later, but only found #{lib.current_command_version.join('.')}. You should probably upgrade."
 end
 
 # Git/Ruby Library
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -645,12 +645,26 @@ def archive(sha, file = nil, opts = {})
     end
 
     # returns the current version of git, as an Array of Fixnums.
-    def command_version
+    def current_command_version
       output = command('version', [], false)
       version = output[/(\d+)\.(\d+)\.(\d+)\.(\d+)/]
       version.split('.').collect {|i| i.to_i}
     end
 
+    def required_command_version
+      [1, 6, 0, 0]
+    end
+
+    def meets_required_version?
+      current_version  = self.current_command_version
+      required_version = self.required_command_version
+      return current_version[0] >= required_version[0] && 
+             current_version[1] >= required_version[1] &&
+             current_version[2] >= required_version[2] &&
+             current_version[3] >= required_version[3]
+    end
+
+
     private
     
     def command_lines(cmd, opts = [], chdir = true, redirect = '')
