BUG27991948: unread_result is not unset after invoke get_rows on c-ext

isrgomez · isrgomez · commit f85d3e6f4708 · 2018-06-08T12:39:44.000-05:00
The invocation of cmd_query after retrieve the results of a previews
query with get_rows raise an InternalError: "Unread result found"
this is because the unread_result property is not automatically set
to false after the results are read.

This patch improves the usability of the c-extension by unseting
the unread_result property to mimic the behavior of the pure
python implementation that set to false this variable when the
results had been read, with this change the user will not
require to invoke the free_result method in order of reuse
the same connection to run a new query.
diff --git a/tests/test_bugs.py b/tests/test_bugs.py
@@ -4693,6 +4693,49 @@ def test_executemany_utf8mb4(self):
         )
 
 
+@unittest.skipIf(not CMySQLConnection, ERR_NO_CEXT)
+class BugOra27991948(tests.MySQLConnectorTests):
+    """BUG#27991948: UNREAD_RESULT IS NOT UNSET AFTER INVOKE GET_ROWS ON C-EXT
+    """
+    test_sql_single_result = "show variables like '%port%'"
+    cnx_cext = None
+    cnx_cext_raw = None
+
+    def setUp(self):
+        config_cext = tests.get_mysql_config()
+        config_cext["use_pure"] = False
+        self.cnx_cext = mysql.connector.connect(**config_cext)
+
+    def tearDown(self):
+        self.cnx_cext.close()
+
+    def test_automatically_set_of_unread_rows(self):
+        """Test unread_rows is automatically set after fetchall()"""
+        # Test get all the rows and execute a query without invoke free_result
+        self.cnx_cext.cmd_query(self.test_sql_single_result)
+        unread_result = self.cnx_cext.unread_result
+        self.assertTrue(unread_result, "unread_rows is expected to be True")
+        _ = self.cnx_cext.get_rows()
+        unread_result = self.cnx_cext.unread_result
+        self.assertFalse(unread_result, "unread_rows was not set to False")
+        # Query execution must not raise InternalError: Unread result found
+        self.cnx_cext.cmd_query(self.test_sql_single_result)
+        _ = self.cnx_cext.get_rows()
+
+        # Test cursor fetchall
+        cur_cext = self.cnx_cext.cursor()
+        cur_cext.execute(self.test_sql_single_result)
+        unread_result = self.cnx_cext.unread_result
+        self.assertTrue(unread_result, "unread_rows is expected to be True")
+        _ = cur_cext.fetchall()
+        unread_result = self.cnx_cext.unread_result
+        self.assertFalse(unread_result, "unread_rows was not set to False")
+        # Query execution must not raise InternalError: Unread result found
+        cur_cext.execute(self.test_sql_single_result)
+        _ = cur_cext.fetchall()
+
+        cur_cext.close()
+
 @unittest.skipIf(tests.MYSQL_VERSION < (8, 0, 1),
                  "Collation utf8mb4_0900_ai_ci not available on 5.7.x")
 class BugOra27277964(tests.MySQLConnectorTests):
