Reduce callproc roundtrip time (PyMySQL#636)

methane · web-flow · commit 9c1b0d809955 · 2018-03-15T02:42:29.000+09:00
Make only one single call to SET variables used as procedure parameters
diff --git a/pymysql/cursors.py b/pymysql/cursors.py
@@ -262,9 +262,10 @@ def callproc(self, procname, args=()):
         disconnected.
         """
         conn = self._get_db()
-        for index, arg in enumerate(args):
-            q = "SET @_%s_%d=%s" % (procname, index, conn.escape(arg))
-            self._query(q)
+        if args:
+            fmt = '@_{0}_%d=%s'.format(procname)
+            self._query('SET %s' % ','.join(fmt % (index, conn.escape(arg))
+                                            for index, arg in enumerate(args)))
             self.nextset()
 
         q = "CALL %s(%s)" % (procname,
