fix: remove -fixed class on component destroy

xidedix · xidedix · commit da2462cefc68 · 2018-12-05T13:00:27.000+01:00
diff --git a/projects/coreui/angular/src/lib/aside/app-aside.component.ts b/projects/coreui/angular/src/lib/aside/app-aside.component.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Input, OnInit } from '@angular/core';
+import { Component, ElementRef, Input, OnInit, OnDestroy } from '@angular/core';
 import { asideMenuCssClasses, Replace } from './../shared/index';
 
 @Component({
@@ -9,19 +9,24 @@ import { asideMenuCssClasses, Replace } from './../shared/index';
     </aside>
   `
 })
-export class AppAsideComponent implements OnInit {
+export class AppAsideComponent implements OnInit, OnDestroy {
   @Input() display: any;
   @Input() fixed: boolean;
   @Input() offCanvas: boolean;
 
   constructor(private el: ElementRef) {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     Replace(this.el);
     this.isFixed(this.fixed);
+    this.isOffCanvas(this.offCanvas);
     this.displayBreakpoint(this.display);
   }
 
+  ngOnDestroy(): void {
+      document.body.classList.remove('aside-menu-fixed');
+  }
+
   isFixed(fixed: boolean): void {
     if (this.fixed) { document.querySelector('body').classList.add('aside-menu-fixed'); }
   }
diff --git a/projects/coreui/angular/src/lib/breadcrumb/app-breadcrumb.component.ts b/projects/coreui/angular/src/lib/breadcrumb/app-breadcrumb.component.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Input, OnInit  } from '@angular/core';
+import { Component, ElementRef, Input, OnInit, OnDestroy } from '@angular/core';
 import { Replace } from './../shared';
 import { AppBreadcrumbService } from './app-breadcrumb.service';
 
@@ -15,7 +15,7 @@ import { AppBreadcrumbService } from './app-breadcrumb.service';
     </ng-template>
   `
 })
-export class AppBreadcrumbComponent implements OnInit {
+export class AppBreadcrumbComponent implements OnInit, OnDestroy {
   @Input() fixed: boolean;
   public breadcrumbs;
 
@@ -27,6 +27,10 @@ export class AppBreadcrumbComponent implements OnInit {
     this.breadcrumbs = this.service.breadcrumbs;
   }
 
+  ngOnDestroy(): void {
+    document.body.classList.remove('breadcrumb-fixed');
+  }
+
   isFixed(fixed: boolean): void {
     if (this.fixed) { document.querySelector('body').classList.add('breadcrumb-fixed'); }
   }
diff --git a/projects/coreui/angular/src/lib/footer/app-footer.component.ts b/projects/coreui/angular/src/lib/footer/app-footer.component.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Input, OnInit  } from '@angular/core';
+import { Component, ElementRef, Input, OnInit, OnDestroy } from '@angular/core';
 import { Replace } from './../shared';
 
 @Component({
@@ -9,16 +9,20 @@ import { Replace } from './../shared';
     </footer>
   `
 })
-export class AppFooterComponent implements OnInit {
+export class AppFooterComponent implements OnInit, OnDestroy {
   @Input() fixed: boolean;
 
   constructor(private el: ElementRef) {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     Replace(this.el);
     this.isFixed(this.fixed);
   }
 
+  ngOnDestroy(): void {
+    document.body.classList.remove('footer-fixed');
+  }
+
   isFixed(fixed: boolean): void {
     if (this.fixed) { document.querySelector('body').classList.add('footer-fixed'); }
   }
diff --git a/projects/coreui/angular/src/lib/header/app-header.component.ts b/projects/coreui/angular/src/lib/header/app-header.component.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Input, OnInit } from '@angular/core';
+import { Component, ElementRef, Input, OnInit, OnDestroy } from '@angular/core';
 import { Replace } from './../shared';
 
 @Component({
@@ -51,7 +51,7 @@ import { Replace } from './../shared';
     </header>
   `
 })
-export class AppHeaderComponent implements OnInit {
+export class AppHeaderComponent implements OnInit, OnDestroy {
 
   @Input() fixed: boolean;
 
@@ -67,11 +67,15 @@ export class AppHeaderComponent implements OnInit {
 
   constructor(private el: ElementRef) {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     Replace(this.el);
     this.isFixed(this.fixed);
   }
 
+  ngOnDestroy(): void {
+    document.body.classList.remove('header-fixed');
+  }
+
   isFixed(fixed: boolean): void {
     if (this.fixed) { document.querySelector('body').classList.add('header-fixed'); }
   }
diff --git a/projects/coreui/angular/src/lib/sidebar/app-sidebar.component.ts b/projects/coreui/angular/src/lib/sidebar/app-sidebar.component.ts
@@ -1,11 +1,11 @@
-import { Component, Input, HostBinding, OnInit } from '@angular/core';
+import { Component, Input, HostBinding, OnInit, OnDestroy } from '@angular/core';
 import { sidebarCssClasses } from './../shared';
 
 @Component({
   selector: 'app-sidebar',
   template: `<ng-content></ng-content>`
 })
-export class AppSidebarComponent implements OnInit {
+export class AppSidebarComponent implements OnInit, OnDestroy {
   @Input() compact: boolean;
   @Input() display: any;
   @Input() fixed: boolean;
@@ -16,14 +16,18 @@ export class AppSidebarComponent implements OnInit {
 
   constructor() {}
 
-  ngOnInit() {
+  ngOnInit(): void {
     this.displayBreakpoint(this.display);
     this.isCompact(this.compact);
     this.isFixed(this.fixed);
     this.isMinimized(this.minimized);
     this.isOffCanvas(this.offCanvas);
   }
 
+  ngOnDestroy(): void {
+    document.body.classList.remove('sidebar-fixed');
+  }
+
   isCompact(compact: boolean): void {
     if (this.compact) { document.querySelector('body').classList.add('sidebar-compact'); }
   }
@@ -41,6 +45,7 @@ export class AppSidebarComponent implements OnInit {
   }
 
   fixedPosition(fixed: boolean): void {
+    console.warn('fixedPosition() is deprecated, use isFixed() instead')
     if (this.fixed) { document.querySelector('body').classList.add('sidebar-fixed'); }
   }
 
