Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve amp-ad loading experience #5918

Closed
6 of 7 tasks
zhouyx opened this issue Oct 31, 2016 · 4 comments
Closed
6 of 7 tasks

Improve amp-ad loading experience #5918

zhouyx opened this issue Oct 31, 2016 · 4 comments
Assignees
@zhouyx @lannka
Labels
Type: Feature Request WG: monetization
Milestone
To be deprecated ...

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Oct 31, 2016 •
edited by lannka
Loading

This is a tracker issue for related work on improving default ad loading experience.

  • Add experiment guard to the new UX
  • Add default placeholder/fallback, apply/remove at right time
  • Create ad tag
  • Create new loading indicator, animate/remove loading dot at right time.
  • Enable a way to customize ad tag
  • Customize behavior for ad in special container
  • support i118
@ericlindley-g ericlindley-g added this to the Pending Triage milestone Nov 3, 2016
@jasti jasti modified the milestones: Current, Pending Triage Dec 2, 2016
This was referenced Dec 9, 2016
Merged
Merged
This was referenced Dec 20, 2016
Closed
Closed
@spacedino
Copy link

@edlea-g

@lannka lannka mentioned this issue Jan 23, 2017
Merged
@lannka
Copy link
Contributor

lannka commented Jan 24, 2017

Enable a way to customize ad tag
support i118

The ad logo can be customized (e.g. for i18n purpose) via CSS.

Customize behavior for ad in special container

I'm not sure what this means.

Otherwise, the work is all done. We can launch it by flipping the flag if it sounds good.
@jasti

@lannka lannka self-assigned this Jan 24, 2017
@jasti
Copy link
Contributor

jasti commented Jan 24, 2017

I'm not sure myself.
Sounds good to me to launch this week to canary. Thanks for the quick work on this!
CC @ericlindley-g

@ericlindley-g
Copy link
Contributor

Excited to see this roll out! Personally I've really been enjoying the experience through the experiment :) We can think about how to extend this to other lazy-loaded UI (images, videos, embeds, iframes) after getting feedback from this ads case.

This was referenced Jan 24, 2017
Merged
Merged
@lannka lannka mentioned this issue Feb 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

@lannka lannka

Labels
Type: Feature Request WG: monetization
Projects
None yet
Milestone
To be deprecated - Current
Development

No branches or pull requests
6 participants
@aghassemi @jasti @zhouyx @spacedino @lannka @ericlindley-g