Fix test case panics (microsoft#381)

ahejlsberg · web-flow · commit e2fc7e406714 · 2025-02-25T09:34:37.000-08:00
diff --git a/internal/ast/ast.go b/internal/ast/ast.go
@@ -543,7 +543,7 @@ func (n *Node) PropertyName() *Node {
 	case KindBindingElement:
 		return n.AsBindingElement().PropertyName
 	}
-	panic("Unhandled case in Node.PropertyName: " + n.Kind.String())
+	return nil
 }
 
 func (n *Node) PropertyNameOrName() *Node {
diff --git a/internal/ast/utilities.go b/internal/ast/utilities.go
@@ -833,12 +833,12 @@ func WalkUpParenthesizedTypes(node *TypeNode) *Node {
 
 // Walks up the parents of a node to find the containing SourceFile
 func GetSourceFileOfNode(node *Node) *SourceFile {
-	for node.Parent != nil {
+	for node != nil {
+		if node.Kind == KindSourceFile {
+			return node.AsSourceFile()
+		}
 		node = node.Parent
 	}
-	if node.Kind == KindSourceFile {
-		return node.AsSourceFile()
-	}
 	return nil
 }
 
diff --git a/internal/checker/checker.go b/internal/checker/checker.go
@@ -4908,7 +4908,7 @@ func (c *Checker) getTypeFromImportAttributes(node *ast.Node) *Type {
 		members := make(ast.SymbolTable)
 		for _, attr := range node.AsImportAttributes().Attributes.Nodes {
 			member := c.newSymbol(ast.SymbolFlagsProperty, attr.Name().Text())
-			c.valueSymbolLinks.Get(symbol).resolvedType = c.getRegularTypeOfLiteralType(c.checkExpression(attr.AsImportAttribute().Value))
+			c.valueSymbolLinks.Get(member).resolvedType = c.getRegularTypeOfLiteralType(c.checkExpression(attr.AsImportAttribute().Value))
 			members[member.Name] = member
 		}
 		t := c.newAnonymousType(symbol, members, nil, nil, nil)
@@ -6100,7 +6100,7 @@ func (c *Checker) checkAliasSymbol(node *ast.Node) {
 					default:
 						message = diagnostics.X_0_resolves_to_a_type_only_declaration_and_must_be_imported_using_a_type_only_import_when_verbatimModuleSyntax_is_enabled
 					}
-					name := core.IfElse(ast.IsImportSpecifier(node), node.PropertyNameOrName(), node.Name()).Text()
+					name := node.PropertyNameOrName().Text()
 					c.addTypeOnlyDeclarationRelatedInfo(c.error(node, message, name), core.IfElse(isType, nil, typeOnlyAlias), name)
 				}
 				if isType && node.Kind == ast.KindImportEqualsDeclaration && hasEffectiveModifier(node, ast.ModifierFlagsExport) {
@@ -25573,10 +25573,10 @@ func (c *Checker) markExportSpecifierAliasReferenced(location *ast.ExportSpecifi
 			// Do nothing, non-local symbol
 		} else {
 			target := symbol
-			if symbol.Flags&ast.SymbolFlagsAlias != 0 {
+			if target != nil && target.Flags&ast.SymbolFlagsAlias != 0 {
 				target = c.resolveAlias(target)
 			}
-			if target != nil || c.getSymbolFlags(target)&ast.SymbolFlagsValue != 0 {
+			if target == nil || c.getSymbolFlags(target)&ast.SymbolFlagsValue != 0 {
 				c.markExportAsReferenced(location)            // marks export as used
 				c.markIdentifierAliasReferenced(exportedName) // marks target of export as used
 			}

Original file line number	Diff line number	Diff line change
`@@ -543,7 +543,7 @@ func (n Node) PropertyName() Node {`
`543`	`543`	`case KindBindingElement:`
`544`	`544`	`return n.AsBindingElement().PropertyName`
`545`	`545`	`}`
`546`		`- panic("Unhandled case in Node.PropertyName: " + n.Kind.String())`
	`546`	`+ return nil`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`func (n Node) PropertyNameOrName() Node {`
Original file line number	Diff line number	Diff line change
`@@ -4908,7 +4908,7 @@ func (c Checker) getTypeFromImportAttributes(node ast.Node) *Type {`
`4908`	`4908`	`members := make(ast.SymbolTable)`
`4909`	`4909`	`for _, attr := range node.AsImportAttributes().Attributes.Nodes {`
`4910`	`4910`	`member := c.newSymbol(ast.SymbolFlagsProperty, attr.Name().Text())`
`4911`		`- c.valueSymbolLinks.Get(symbol).resolvedType = c.getRegularTypeOfLiteralType(c.checkExpression(attr.AsImportAttribute().Value))`
	`4911`	`+ c.valueSymbolLinks.Get(member).resolvedType = c.getRegularTypeOfLiteralType(c.checkExpression(attr.AsImportAttribute().Value))`
`4912`	`4912`	`members[member.Name] = member`
`4913`	`4913`	`}`
`4914`	`4914`	`t := c.newAnonymousType(symbol, members, nil, nil, nil)`
`@@ -6100,7 +6100,7 @@ func (c Checker) checkAliasSymbol(node ast.Node) {`
`6100`	`6100`	`default:`
`6101`	`6101`	`message = diagnostics.X_0_resolves_to_a_type_only_declaration_and_must_be_imported_using_a_type_only_import_when_verbatimModuleSyntax_is_enabled`
`6102`	`6102`	`}`
`6103`		`- name := core.IfElse(ast.IsImportSpecifier(node), node.PropertyNameOrName(), node.Name()).Text()`
	`6103`	`+ name := node.PropertyNameOrName().Text()`
`6104`	`6104`	`c.addTypeOnlyDeclarationRelatedInfo(c.error(node, message, name), core.IfElse(isType, nil, typeOnlyAlias), name)`
`6105`	`6105`	`}`
`6106`	`6106`	`if isType && node.Kind == ast.KindImportEqualsDeclaration && hasEffectiveModifier(node, ast.ModifierFlagsExport) {`
`@@ -25573,10 +25573,10 @@ func (c Checker) markExportSpecifierAliasReferenced(location ast.ExportSpecifi`
`25573`	`25573`	`// Do nothing, non-local symbol`
`25574`	`25574`	`} else {`
`25575`	`25575`	`target := symbol`
`25576`		`- if symbol.Flags&ast.SymbolFlagsAlias != 0 {`
	`25576`	`+ if target != nil && target.Flags&ast.SymbolFlagsAlias != 0 {`
`25577`	`25577`	`target = c.resolveAlias(target)`
`25578`	`25578`	`}`
`25579`		`- if target != nil \|\| c.getSymbolFlags(target)&ast.SymbolFlagsValue != 0 {`
	`25579`	`+ if target == nil \|\| c.getSymbolFlags(target)&ast.SymbolFlagsValue != 0 {`
`25580`	`25580`	`c.markExportAsReferenced(location) // marks export as used`
`25581`	`25581`	`c.markIdentifierAliasReferenced(exportedName) // marks target of export as used`
`25582`	`25582`	`}`