Skip to content

ability to add headers easily #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bryankemp opened this issue Jul 14, 2011 · 12 comments
Closed

ability to add headers easily #5

bryankemp opened this issue Jul 14, 2011 · 12 comments
Assignees
Milestone

Comments

@bryankemp
Copy link

I noticed reading through the code that changing the user-agent is exposed, but changing the adding headers is not. That would be awesome.

@jlsuttles
Copy link
Contributor

+1 I would like to set the content type.

@loopj
Copy link
Collaborator

loopj commented Aug 10, 2011

I'm thinking about the best (cleanest) way to implement this, I will get back to you guys.

@loopj
Copy link
Collaborator

loopj commented Aug 10, 2011

Any suggestions welcome of course! :)

@loopj
Copy link
Collaborator

loopj commented Aug 11, 2011

@Simperium added "client-wide" header support in this commit, which could be useful for you guys:
Simperium@825f655

I'm planning of adding per-request custom headers since these are more flexible

@shnhrrsn
Copy link

+1.. I think the cleanest way to do it would be to build it into RequestParams

@bryankemp
Copy link
Author

I agree with shnhrrsn. Wow. what a name ;-)

@kueda
Copy link

kueda commented Dec 28, 2011

+1, client-wide or per-request. This would be really useful.

@tunix
Copy link

tunix commented Feb 20, 2012

+1 - this feature is really important since i've to send json encoded body to server side.

@tunix
Copy link

tunix commented Feb 20, 2012

@loopj any roadmaps for this feature?

@dbrgn
Copy link

dbrgn commented Apr 24, 2012

+1 for this feature.

1 similar comment
@poiuytrez
Copy link

+1 for this feature.

@ghost ghost assigned smarek Oct 12, 2013
@smarek
Copy link
Member

smarek commented Oct 12, 2013

As of now, I see Header[] param array for all GET,POST,PUT,DELETE,HEAD requests, see AsyncHttpClient class. I consider this issue fixed, although I plan to move the feature to RequestParams as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants