fix(compiler): avoid a crash in ngc-wrapped. (#23468)

mprobst · vicb · commit 0bc8443e126d · 2018-04-24T13:57:04.000-07:00
`ng.performCompilation` can return an `undefined` program, which is not handled by ngc-wrapped. Avoid crashing by checking for the error return and returning the diagnostics. PR Close #23468
diff --git a/packages/bazel/src/ngc-wrapped/index.ts b/packages/bazel/src/ngc-wrapped/index.ts
@@ -267,6 +267,10 @@ export function compile({allowNonHermeticReads, allDepsCompiledWithBazel = true,
       fs.writeFileSync(bazelOpts.manifest, manifest);
     }
   }
+  
+  // If compilation fails unexpectedly, performCompilation returns no program.
+  // Make sure not to crash but report the diagnostics.
+  if (!program) return {program, diagnostics};
 
   if (!bazelOpts.nodeModulesPrefix) {
     // If there is no node modules, then metadata.json should be emitted since

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,10 @@ export function compile({allowNonHermeticReads, allDepsCompiledWithBazel = true,`
`267`	`267`	`fs.writeFileSync(bazelOpts.manifest, manifest);`
`268`	`268`	`}`
`269`	`269`	`}`
	`270`	`+`
	`271`	`+ // If compilation fails unexpectedly, performCompilation returns no program.`
	`272`	`+ // Make sure not to crash but report the diagnostics.`
	`273`	`+ if (!program) return {program, diagnostics};`
`270`	`274`
`271`	`275`	`if (!bazelOpts.nodeModulesPrefix) {`
`272`	`276`	`// If there is no node modules, then metadata.json should be emitted since`