build: enable strict templates and type checking of host bindings (#60481)

crisbeto · alxhub · commit 2637a0cdad97 · 2025-03-20T11:55:52.000-07:00
Enables strict templates and type checking of host bindings against our own code. PR Close #60481
diff --git a/modules/tsconfig.json b/modules/tsconfig.json
@@ -20,14 +20,16 @@
     "skipDefaultLibCheck": true,
     "skipLibCheck": true,
     "target": "es5",
-    "types": ["angular"],
+    "types": ["angular"]
   },
   "exclude": [
     "payload_tests",
     "playground/",
     "benchmarks/"
   ],
   "angularCompilerOptions": {
-    "skipTemplateCodegen": true
+    "strictTemplates": true,
+    "skipTemplateCodegen": true,
+    "typeCheckHostBindings": true
   }
 }
diff --git a/packages/bazel/test/ngc-wrapped/ivy_enabled/BUILD.bazel b/packages/bazel/test/ngc-wrapped/ivy_enabled/BUILD.bazel
@@ -28,7 +28,6 @@ jasmine_node_test(
 ng_module(
     name = "test_module_warnings_lib",
     srcs = ["test_module_warnings.ts"],
-    strict_templates = True,
     tags = [],
     deps = ["//packages/core"],
 )
diff --git a/packages/core/test/playground/zone-signal-input/BUILD.bazel b/packages/core/test/playground/zone-signal-input/BUILD.bazel
@@ -3,7 +3,6 @@ load("//tools:defaults.bzl", "app_bundle", "http_server", "ng_module")
 ng_module(
     name = "test_lib",
     srcs = ["index.ts"],
-    strict_templates = True,
     tags = ["no-cache"],
     deps = [
         "//packages/core",
diff --git a/packages/tsconfig-build.json b/packages/tsconfig-build.json
@@ -33,5 +33,9 @@
   },
   "bazelOptions": {
     "suppressTsconfigOverrideWarnings": true
+  },
+  "angularCompilerOptions": {
+    "strictTemplates": true,
+    "typeCheckHostBindings": true
   }
 }
diff --git a/packages/tsconfig.json b/packages/tsconfig.json
@@ -37,6 +37,10 @@
   "bazelOptions": {
     "suppressTsconfigOverrideWarnings": true
   },
+  "angularCompilerOptions": {
+    "strictTemplates": true,
+    "typeCheckHostBindings": true
+  },
   "exclude": [
     "common/locales",
     "compiler-cli/integrationtest",
diff --git a/tools/defaults.bzl b/tools/defaults.bzl
@@ -184,6 +184,7 @@ def ng_module(name, tsconfig = None, entry_point = None, testonly = False, deps
         deps = deps,
         compiler = _INTERNAL_NG_MODULE_COMPILER,
         ng_xi18n = _INTERNAL_NG_MODULE_XI18N,
+        strict_templates = True,
         # `module_name` is used for AMD module names within emitted JavaScript files.
         module_name = module_name,
         # `package_name` can be set to allow for the Bazel NodeJS linker to run. This

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ jasmine_node_test(`
`28`	`28`	`ng_module(`
`29`	`29`	`name = "test_module_warnings_lib",`
`30`	`30`	`srcs = ["test_module_warnings.ts"],`
`31`		`- strict_templates = True,`
`32`	`31`	`tags = [],`
`33`	`32`	`deps = ["//packages/core"],`
`34`	`33`	`)`
Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,9 @@`
`33`	`33`	`},`
`34`	`34`	`"bazelOptions": {`
`35`	`35`	`"suppressTsconfigOverrideWarnings": true`
	`36`	`+ },`
	`37`	`+ "angularCompilerOptions": {`
	`38`	`+ "strictTemplates": true,`
	`39`	`+ "typeCheckHostBindings": true`
`36`	`40`	`}`
`37`	`41`	`}`