fix(compiler): do not emit line/char in ngsummary files. (#22840)

rkirov · mhevery · commit 5c387a7f3c0f · 2018-03-19T16:01:41.000-07:00
Having ngsummaries emit line/char numbers causes white space change to retrigger upstream recompilations. PR Close #22840
diff --git a/packages/compiler/src/aot/summary_serializer.ts b/packages/compiler/src/aot/summary_serializer.ts
@@ -221,6 +221,24 @@ class ToJsonSerializer extends ValueTransformer {
     }
   }
 
+  /**
+   * Strip line and character numbers from ngsummaries.
+   * Emitting them causes white spaces changes to retrigger upstream
+   * recompilations in bazel.
+   * TODO: find out a way to have line and character numbers in errors without
+   * excessive recompilation in bazel.
+   */
+  visitStringMap(map: {[key: string]: any}, context: any): any {
+    if (map['__symbolic'] === 'resolved') {
+      return visitValue(map.symbol, this, context);
+    }
+    if (map['__symbolic'] === 'error') {
+      delete map['line'];
+      delete map['character'];
+    }
+    return super.visitStringMap(map, context);
+  }
+
   /**
    * Returns null if the options.resolveValue is true, and the summary for the symbol
    * resolved to a type or could not be resolved.
