From 9354efc86a52b963f093ac4892cb9f6ac03c400d Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Thu, 5 Jun 2025 14:58:33 +0000 Subject: [PATCH 1/3] build: remove unnecessary zone.js dep from various build targets (#61901) Remove unnecessary zone.js dep from various build targets PR Close #61901 --- packages/common/http/BUILD.bazel | 1 - packages/core/test/BUILD.bazel | 2 -- packages/core/test/acceptance/BUILD.bazel | 2 -- packages/core/test/acceptance/selectorless/BUILD | 2 -- packages/core/test/render3/BUILD.bazel | 1 - packages/core/testing/BUILD.bazel | 1 - packages/platform-browser/BUILD.bazel | 1 - packages/platform-server/BUILD.bazel | 1 - packages/upgrade/BUILD.bazel | 1 - 9 files changed, 12 deletions(-) diff --git a/packages/common/http/BUILD.bazel b/packages/common/http/BUILD.bazel index ce34fb8be081..7f17d67bdf44 100644 --- a/packages/common/http/BUILD.bazel +++ b/packages/common/http/BUILD.bazel @@ -15,7 +15,6 @@ ng_project( ), interop_deps = [ "//packages/core", - "//packages/zone.js/lib:zone_d_ts", ], deps = [ "//:node_modules/rxjs", diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel index 11aa1376ef9b..daf0784a587b 100644 --- a/packages/core/test/BUILD.bazel +++ b/packages/core/test/BUILD.bazel @@ -68,7 +68,6 @@ ts_project( "//packages/private/testing", "//packages/router", "//packages/router/testing", - "//packages/zone.js/lib:zone_d_ts", ], # Visible to //:saucelabs_unit_tests_poc target visibility = ["//:__pkg__"], @@ -112,7 +111,6 @@ jasmine_node_test( ":test_node_only_lib", "//packages/platform-server", "//packages/platform-server/testing", - "//packages/zone.js/lib:zone_d_ts", "@npm//source-map", ], ) diff --git a/packages/core/test/acceptance/BUILD.bazel b/packages/core/test/acceptance/BUILD.bazel index aea3d6e05114..6a0d41711e28 100644 --- a/packages/core/test/acceptance/BUILD.bazel +++ b/packages/core/test/acceptance/BUILD.bazel @@ -35,7 +35,6 @@ ts_project( "//packages/platform-server", "//packages/private/testing", "//packages/router", - "//packages/zone.js/lib:zone_d_ts", ], # Visible to //:saucelabs_unit_tests visibility = ["//:__pkg__"], @@ -66,7 +65,6 @@ jasmine_node_test( deps = [ ":acceptance_lib", ":forward_ref_test_lib", - "//packages/zone.js/lib:zone_d_ts", "@npm//source-map", ], ) diff --git a/packages/core/test/acceptance/selectorless/BUILD b/packages/core/test/acceptance/selectorless/BUILD index 5f1d302f3e63..e73401d3b729 100644 --- a/packages/core/test/acceptance/selectorless/BUILD +++ b/packages/core/test/acceptance/selectorless/BUILD @@ -11,7 +11,6 @@ ng_project( interop_deps = [ "//packages/core", "//packages/core/testing", - "//packages/zone.js/lib:zone_d_ts", ], tsconfig = ":tsconfig.json", visibility = ["//:__pkg__"], @@ -22,7 +21,6 @@ jasmine_node_test( bootstrap = ["//tools/testing:node"], deps = [ ":selectorless_test_lib", - "//packages/zone.js/lib:zone_d_ts", "@npm//source-map", ], ) diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel index 80c5f548ec8b..7a158566e144 100644 --- a/packages/core/test/render3/BUILD.bazel +++ b/packages/core/test/render3/BUILD.bazel @@ -64,7 +64,6 @@ ts_project( "//packages/compiler", "//packages/platform-server", "//packages/platform-server:bundled_domino_lib", - "//packages/zone.js/lib:zone_d_ts", ], ) diff --git a/packages/core/testing/BUILD.bazel b/packages/core/testing/BUILD.bazel index 536d83d9c8a5..e4677a1f7f81 100644 --- a/packages/core/testing/BUILD.bazel +++ b/packages/core/testing/BUILD.bazel @@ -13,7 +13,6 @@ ng_project( "//packages/core", "//packages/core/primitives/dom-navigation/testing", "//packages/localize", - "//packages/zone.js/lib:zone_d_ts", ], deps = [ "//:node_modules/@types/jasmine", diff --git a/packages/platform-browser/BUILD.bazel b/packages/platform-browser/BUILD.bazel index fe9d4001decf..5a48e4ea8988 100644 --- a/packages/platform-browser/BUILD.bazel +++ b/packages/platform-browser/BUILD.bazel @@ -13,7 +13,6 @@ ng_project( ), interop_deps = [ "//packages:types", - "//packages/zone.js/lib:zone_d_ts", ], deps = [ "//:node_modules/@types/hammerjs", diff --git a/packages/platform-server/BUILD.bazel b/packages/platform-server/BUILD.bazel index 99a8980bcaff..b65810912d49 100644 --- a/packages/platform-server/BUILD.bazel +++ b/packages/platform-server/BUILD.bazel @@ -18,7 +18,6 @@ ng_project( "//packages/common/http", "//packages/compiler", "//packages/platform-browser", - "//packages/zone.js/lib:zone_d_ts", ":bundled_domino_lib", ], deps = [ diff --git a/packages/upgrade/BUILD.bazel b/packages/upgrade/BUILD.bazel index e5399ae041ef..c04d78896401 100644 --- a/packages/upgrade/BUILD.bazel +++ b/packages/upgrade/BUILD.bazel @@ -14,7 +14,6 @@ ng_project( interop_deps = [ "//packages/core", "//packages/platform-browser-dynamic", - "//packages/zone.js/lib:zone_d_ts", ], deps = [ "//packages/upgrade/src/common:common_rjs", From cfb0dc2cbc03e67d081b6fda840315f7ed7025a7 Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Thu, 5 Jun 2025 17:09:18 -0700 Subject: [PATCH 2/3] fix(docs-infra): Fix import name for house location (#61914) This fixes the import name for the HouseLocation component PR Close #61914 --- .../steps/07-dynamic-template-values/src/app/home/home.ts | 2 +- .../tutorials/first-app/steps/09-services/src/app/home/home.ts | 2 +- .../tutorials/first-app/steps/10-routing/src/app/home/home.ts | 2 +- .../first-app/steps/11-details-page/src/app/home/home.ts | 2 +- .../tutorials/first-app/steps/12-forms/src/app/home/home.ts | 2 +- .../tutorials/first-app/steps/13-search/src/app/home/home.ts | 2 +- .../first-app/steps/14-http/src-final/app/home/home.ts | 2 +- .../tutorials/first-app/steps/14-http/src/app/home/home.ts | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/adev/src/content/tutorials/first-app/steps/07-dynamic-template-values/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/07-dynamic-template-values/src/app/home/home.ts index 54a16e327458..587728d024dd 100644 --- a/adev/src/content/tutorials/first-app/steps/07-dynamic-template-values/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/07-dynamic-template-values/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; @Component({ diff --git a/adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts index 79bed4f750b4..be3660f0f67f 100644 --- a/adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/09-services/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; @Component({ diff --git a/adev/src/content/tutorials/first-app/steps/10-routing/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/10-routing/src/app/home/home.ts index cd5a476b48a5..d75bb8884867 100644 --- a/adev/src/content/tutorials/first-app/steps/10-routing/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/10-routing/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; @Component({ diff --git a/adev/src/content/tutorials/first-app/steps/11-details-page/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/11-details-page/src/app/home/home.ts index 4a04e91a7ccc..85d8a6b9595c 100644 --- a/adev/src/content/tutorials/first-app/steps/11-details-page/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/11-details-page/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; diff --git a/adev/src/content/tutorials/first-app/steps/12-forms/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/12-forms/src/app/home/home.ts index 4a04e91a7ccc..85d8a6b9595c 100644 --- a/adev/src/content/tutorials/first-app/steps/12-forms/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/12-forms/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; diff --git a/adev/src/content/tutorials/first-app/steps/13-search/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/13-search/src/app/home/home.ts index 4a04e91a7ccc..85d8a6b9595c 100644 --- a/adev/src/content/tutorials/first-app/steps/13-search/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/13-search/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; diff --git a/adev/src/content/tutorials/first-app/steps/14-http/src-final/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/14-http/src-final/app/home/home.ts index 29663093c873..1ca48e11eeef 100644 --- a/adev/src/content/tutorials/first-app/steps/14-http/src-final/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/14-http/src-final/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; diff --git a/adev/src/content/tutorials/first-app/steps/14-http/src/app/home/home.ts b/adev/src/content/tutorials/first-app/steps/14-http/src/app/home/home.ts index aea67d72817d..a6720a1d2c19 100644 --- a/adev/src/content/tutorials/first-app/steps/14-http/src/app/home/home.ts +++ b/adev/src/content/tutorials/first-app/steps/14-http/src/app/home/home.ts @@ -1,6 +1,6 @@ import {Component, inject} from '@angular/core'; import {CommonModule} from '@angular/common'; -import {HousingLocationInfo} from '../housing-location/housing-location'; +import {HousingLocation} from '../housing-location/housing-location'; import {HousingLocationInfo} from '../housinglocation'; import {HousingService} from '../housing.service'; From 8f9d13ef2bd4ddc10c230ddd0019ef21d9887175 Mon Sep 17 00:00:00 2001 From: sEver Date: Wed, 30 Apr 2025 01:37:15 +0200 Subject: [PATCH 3/3] fix(docs-infra): fix wrong `visibleLines` numbers in `docs-code` blocks (#61909) Many of these were shifted by one line Also fixing one minor typo PR Close #61909 --- .../tutorials/first-app/steps/01-hello-world/README.md | 4 ++-- .../tutorials/first-app/steps/02-Home/README.md | 6 +++--- .../first-app/steps/03-HousingLocation/README.md | 4 ++-- .../tutorials/first-app/steps/04-interfaces/README.md | 4 ++-- .../first-app/steps/11-details-page/README.md | 2 +- .../tutorials/first-app/steps/12-forms/README.md | 10 +++++----- .../tutorials/first-app/steps/13-search/README.md | 6 +++--- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/adev/src/content/tutorials/first-app/steps/01-hello-world/README.md b/adev/src/content/tutorials/first-app/steps/01-hello-world/README.md index bdeae67f3bd3..69e6f2a67e08 100644 --- a/adev/src/content/tutorials/first-app/steps/01-hello-world/README.md +++ b/adev/src/content/tutorials/first-app/steps/01-hello-world/README.md @@ -94,11 +94,11 @@ In your IDE: 1. Next, open `first-app/src/app/app.ts`. 1. In `app.ts`, in the `@Component` definition, replace the `template` line with this code to change the text in the app component. - + 1. In `app.ts`, in the `App` class definition, replace the `title` line with this code to change the component title. - + Then, save the changes you made to `app.ts`. diff --git a/adev/src/content/tutorials/first-app/steps/02-Home/README.md b/adev/src/content/tutorials/first-app/steps/02-Home/README.md index 4007439832d6..c0556a316050 100644 --- a/adev/src/content/tutorials/first-app/steps/02-Home/README.md +++ b/adev/src/content/tutorials/first-app/steps/02-Home/README.md @@ -70,11 +70,11 @@ In the **Edit** pane of your IDE: 1. In `app.ts`, in `@Component`, update the `imports` array property and add `Home`. - + 1. In `app.ts`, in `@Component`, update the `template` property to include the following HTML code. - + 1. Save your changes to `app.ts`. 1. If `ng serve` is running, the app should update. @@ -100,7 +100,7 @@ In the **Edit** pane of your IDE: 1. In the `first-app` directory, open `home.ts` in the editor. 1. In `home.ts`, in `@Component`, update the `template` property with this code. - + 1. Next, open `home.css` in the editor and update the content with these styles. diff --git a/adev/src/content/tutorials/first-app/steps/03-HousingLocation/README.md b/adev/src/content/tutorials/first-app/steps/03-HousingLocation/README.md index 91332a02c899..4d45d8b2d946 100644 --- a/adev/src/content/tutorials/first-app/steps/03-HousingLocation/README.md +++ b/adev/src/content/tutorials/first-app/steps/03-HousingLocation/README.md @@ -51,11 +51,11 @@ In the **Edit** pane of your IDE: 1. Next update the `imports` property of the `@Component` metadata by adding `HousingLocation` to the array. - + 1. Now the component is ready for use in the template for the `Home`. Update the `template` property of the `@Component` metadata to include a reference to the `` tag. - + diff --git a/adev/src/content/tutorials/first-app/steps/04-interfaces/README.md b/adev/src/content/tutorials/first-app/steps/04-interfaces/README.md index 548970bb50ec..d82c564d697f 100644 --- a/adev/src/content/tutorials/first-app/steps/04-interfaces/README.md +++ b/adev/src/content/tutorials/first-app/steps/04-interfaces/README.md @@ -70,9 +70,9 @@ There are a few more lessons to complete before that happens. 1. In `src/app/home/home.ts`, replace the empty `export class Home {}` definition with this code to create a single instance of the new interface in the component. - + -1. Confirm that your `home.ts` file matches like this example. +1. Confirm that your `home.ts` file matches this example. diff --git a/adev/src/content/tutorials/first-app/steps/11-details-page/README.md b/adev/src/content/tutorials/first-app/steps/11-details-page/README.md index 2b65717d6ae2..ba7d28f90db4 100644 --- a/adev/src/content/tutorials/first-app/steps/11-details-page/README.md +++ b/adev/src/content/tutorials/first-app/steps/11-details-page/README.md @@ -72,7 +72,7 @@ In this step, you will get the route parameter in the `Details`. Currently, the 1. In the browser, click on one of the housing location's "Learn More" links and confirm that the numeric value displayed on the page matches the `id` property for that location in the data. - + Now that routing is working properly in the application this is a great time to update the template of the `Details` to display the specific data represented by the housing location for the route parameter. To access the data you will add a call to the `HousingService`. diff --git a/adev/src/content/tutorials/first-app/steps/12-forms/README.md b/adev/src/content/tutorials/first-app/steps/12-forms/README.md index 09ce9e001ed2..6ef7acf53c54 100644 --- a/adev/src/content/tutorials/first-app/steps/12-forms/README.md +++ b/adev/src/content/tutorials/first-app/steps/12-forms/README.md @@ -25,7 +25,7 @@ In the **Edit** pane of your IDE: 1. In `src/app/housing.service.ts`, inside the `HousingService` class, paste this method at the bottom of the class definition. - + 1. Confirm that the app builds without error. Correct any errors before you continue to the next step. @@ -38,21 +38,21 @@ In the **Edit** pane of your IDE, in `src/app/details/details.ts`: 1. After the `import` statements at the top of the file, add the following code to import the Angular form classes. - + 1. In the `Details` decorator metadata, update the `imports` property with the following code: - + 1. In the `Details` class, before the `constructor()` method, add the following code to create the form object. - + In Angular, `FormGroup` and `FormControl` are types that enable you to build forms. The `FormControl` type can provide a default value and shape the form data. In this example `firstName` is a `string` and the default value is empty string. 1. In the `Details` class, after the `constructor()` method, add the following code to handle the **Apply now** click. - + This button does not exist yet - you will add it in the next step. In the above code, the `FormControl`s may return `null`. This code uses the nullish coalescing operator to default to empty string if the value is `null`. diff --git a/adev/src/content/tutorials/first-app/steps/13-search/README.md b/adev/src/content/tutorials/first-app/steps/13-search/README.md index 86f8e5795e49..3bd4aeeaa8a3 100644 --- a/adev/src/content/tutorials/first-app/steps/13-search/README.md +++ b/adev/src/content/tutorials/first-app/steps/13-search/README.md @@ -20,13 +20,13 @@ In this step, you'll update the `Home` class to store data in a new array proper 1. In `src/app/home/home.ts`, add new property to the class called `filteredLocationList`. - + The `filteredLocationList` hold the values that match the search criteria entered by the user. 1. The `filteredLocationList` should contain the total set of housing locations values by default when the page loads. Update the `constructor` for the `Home` to set the value. - + @@ -62,7 +62,7 @@ The template has been updated to bind the `filterResults` function to the `click 1. Update the `Home` class to include the implementation of the `filterResults` function. - + This function uses the `String` `filter` function to compare the value of the `text` parameter against the `housingLocation.city` property. You can update this function to match against any property or multiple properties for a fun exercise.