See if this PR talks about it #21423. If it doesn't it would be a good idea to ask to be added imo

Thanks! I reviewed that PR, I don't see anything. I asked... we'll see!

This topic is evocated at different places in the documentation. We can find example in the Router documentation ;

When subscribing to an observable in a component, you almost always arrange to unsubscribe when the component is destroyed.
There are a few exceptional observables where this is not necessary. The ActivatedRoute observables are among the exceptions.
The ActivatedRoute and its observables are insulated from the Router itself. The Router destroys a routed component when it is no longer needed and the injected ActivatedRoute dies with it.

Feel free to unsubscribe anyway. It is harmless and never a bad practice.

This explain they are, directly related to a technical element (router, Http) rather than a generaly.

This is a good question, and yes, it needs to be documented. I assigned to myself to be addressed in a follow-up to #21423

I added @jbogarthyde as another assignee, so it's on her radar to add this to her backlog for RxJS doc as well.

I collected information about this in a SO answer that has some traction (it appears devs are using the approach I document).

I would be happy to update my answer there again to point to the documentation once it's released.

There is also this issue which was closed asking about a specific scenario of what I assume the PR will cover

Here are some other interesting Stack Overflow posts:

SO Post: Angular2: Unsubscribe from http observable in Service

SO Post: Angular 2 Subscribe / Unsubscribe Observables in case of http calls

Any updates on this? @jasonaden

ummm yea I agree. There needs to be more documentation on this subject. Like the OP, I read some articles and saw some guys making suggestions with async pipe and using other rxjs operators, but I would like to hear it from the angular team on the recommended approach.

Closing as this topic, https://angular.io/guide/observables talks a great deal about unsubscribing. In addition, observables in general are documented in the official RxJS documentation: https://rxjs.dev/guide/subscription

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}