Skip to content

docs: Use signal function to read value in CustomDialog example (programmatic-rendering.md) #61821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: Use signal function to read value in CustomDialog example (programmatic-rendering.md) #61821

wants to merge 1 commit into from

Conversation

oussamabadr
Copy link
Contributor

@oussamabadr oussamabadr commented Jun 2, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Fix a typo in programmatic-rendering.md, by using signal function to read user value in CustomDialog example
  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Fix typo in programmatic-rendering.md

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla Google CLA
Copy link

google-cla bot commented Jun 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from atscott June 2, 2025 11:57
@JeanMeche JeanMeche closed this Jun 2, 2025
@JeanMeche JeanMeche reopened this Jun 2, 2025
JeanMeche
JeanMeche approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche added cla: no action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 2, 2025
@oussamabadr oussamabadr changed the title Use signal function to read value in CustomDialog example (programmatic-rendering.md) doc: Use signal function to read value in CustomDialog example (programmatic-rendering.md) Jun 2, 2025
@oussamabadr oussamabadr changed the title doc: Use signal function to read value in CustomDialog example (programmatic-rendering.md) docs: Use signal function to read value in CustomDialog example (programmatic-rendering.md) Jun 2, 2025
@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 2, 2025
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 2, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 2, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 2, 2025

This PR was merged into the repository by commit 42f07ce.

The changes were merged into the following branches: main, 20.0.x

@kirjs kirjs closed this in 42f07ce Jun 2, 2025
kirjs pushed a commit that referenced this pull request Jun 2, 2025
@oussamabadr @kirjs
docs: Use signal function to read value in CustomDialog example (prog…
13a0fc6 
…rammatic-rendering.md) (#61821)

PR Close #61821
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@atscott atscott Awaiting requested review from atscott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@oussamabadr @kirjs @JeanMeche