Skip to content

Commit e58226e

Browse files
committed
fix(@schematics/angular): don't export renderModuleFactory from server file
Using `renderModuleFactory` is no longer needed since this was used for ViewEngine. (cherry picked from commit 94c00af)
1 parent 98a6493 commit e58226e

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

packages/angular_devkit/build_angular/test/hello-world-app/src/main.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ if (environment.production) {
1616
}
1717

1818
export { AppServerModule } from './app/app.server.module';
19-
export { renderModule, renderModuleFactory } from '@angular/platform-server';
19+
export { renderModule } from '@angular/platform-server';

packages/schematics/angular/universal/files/src/__main@stripTsExtension__.ts.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ if (environment.production) {
2121
}
2222

2323
export { <%= rootModuleClassName %> } from './app/<%= stripTsExtension(rootModuleFileName) %>';
24-
export { renderModule, renderModuleFactory } from '@angular/platform-server';
24+
export { renderModule } from '@angular/platform-server';

tests/legacy-cli/e2e/tests/build/build-app-shell.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,18 @@ import { ng } from '../../utils/process';
66
import { updateJsonFile } from '../../utils/project';
77
import { readNgVersion } from '../../utils/version';
88

9-
export default function() {
9+
export default function () {
1010
let platformServerVersion = readNgVersion();
1111

1212
if (getGlobalVariable('argv')['ng-snapshots']) {
13-
platformServerVersion = require('../../ng-snapshot/package.json')
14-
.dependencies['@angular/platform-server'];
13+
platformServerVersion = require('../../ng-snapshot/package.json').dependencies[
14+
'@angular/platform-server'
15+
];
1516
}
1617

1718
return Promise.resolve()
1819
.then(() =>
19-
updateJsonFile('angular.json', workspaceJson => {
20+
updateJsonFile('angular.json', (workspaceJson) => {
2021
const appArchitect = workspaceJson.projects['test-project'].architect;
2122
appArchitect['server'] = {
2223
builder: '@angular-devkit/build-angular:server',
@@ -74,7 +75,7 @@ export default function() {
7475
}
7576
7677
export { AppServerModule } from './app/app.server.module';
77-
export { renderModule, renderModuleFactory } from '@angular/platform-server';
78+
export { renderModule } from '@angular/platform-server';
7879
`,
7980
),
8081
)
@@ -157,7 +158,7 @@ export default function() {
157158
),
158159
)
159160
.then(() =>
160-
updateJsonFile('package.json', packageJson => {
161+
updateJsonFile('package.json', (packageJson) => {
161162
const dependencies = packageJson['dependencies'];
162163
dependencies['@angular/platform-server'] = platformServerVersion;
163164
}).then(() => installWorkspacePackages()),

0 commit comments

Comments
 (0)