Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Unit tests fail on FF52 on Jenkins #15987

Closed
@Narretz

Description

@Narretz

Since we updated Firefox on Jenkins, one specific unit test fails every time:

it('should not re-set the `selected` property if it already has the correct value', function() {

However, locally this is difficult to reproduce, and Travis never seems to hit the bug.

Some observations:

  • The test uses defineProperty on option elements at these lines:
    Object.defineProperty(option, 'selected', {
    get: function() { return _selected[i]; },
    set: optionsSetSelected[i].and.callFake(function(value) { _selected[i] = value; })
    });
    . When the test fails, the redefined setter / getters is never called
    (We also use defineProperty on other tests that don't fail, but none on option elements)
  • it seems to happen more frequently when the FF window is unfocused and when the CPU usage is very high.
  • Firefox runs the tests much slower than e.g. Chrome, and seems to "hang" at certain points for a few seconds
  • The failure could not be reproduced when the test is isolated with fit.
  • The failure is not dependent on the jasmine.spy
  • happens less frequently in FF53

Possible causes:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions