This repository was archived by the owner on Apr 12, 2024. It is now read-only.
build(travis): gracefully shut down the sauce connect tunnel after th… #12921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petebacondarwin I have a similar PR pending for angular/angular#4329. Based on the logs it seems to work fine. we need to merge this in and see if it improves the situation. |
|
LGTM |
…e tests are done running This is to prevent sauce connect tunnel leaks.
|
I made one more change - we now poll and block travis until the process disappears. |
e4c4b21 to
6a06967
Compare
IgorMinar
added a commit
that referenced
this pull request
Sep 23, 2015
…e tests are done running This is to prevent sauce connect tunnel leaks. Closes #12921
IgorMinar
added a commit
that referenced
this pull request
Sep 23, 2015
…e tests are done running This is to prevent sauce connect tunnel leaks. Closes #12921
IgorMinar
added a commit
that referenced
this pull request
Sep 23, 2015
…e tests are done running This is to prevent sauce connect tunnel leaks. Closes #12921
|
merged into all branches |
|
Fingers crossed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e tests are done running
This is to prevent sauce connect tunnel leaks.