Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

build(travis): gracefully shut down the sauce connect tunnel after th… #12921

Closed
wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

…e tests are done running

This is to prevent sauce connect tunnel leaks.

@IgorMinar
Copy link
Contributor Author

@petebacondarwin I have a similar PR pending for angular/angular#4329. Based on the logs it seems to work fine. we need to merge this in and see if it improves the situation.

@petebacondarwin
Copy link
Contributor

LGTM

…e tests are done running

This is to prevent sauce connect tunnel leaks.
@IgorMinar
Copy link
Contributor Author

I made one more change - we now poll and block travis until the process disappears.

@IgorMinar IgorMinar force-pushed the sauce-connect-teardown branch from e4c4b21 to 6a06967 Compare September 23, 2015 16:39
IgorMinar added a commit that referenced this pull request Sep 23, 2015
…e tests are done running

This is to prevent sauce connect tunnel leaks.

Closes #12921
IgorMinar added a commit that referenced this pull request Sep 23, 2015
…e tests are done running

This is to prevent sauce connect tunnel leaks.

Closes #12921
@IgorMinar IgorMinar closed this in f2724b2 Sep 23, 2015
IgorMinar added a commit that referenced this pull request Sep 23, 2015
…e tests are done running

This is to prevent sauce connect tunnel leaks.

Closes #12921
@IgorMinar
Copy link
Contributor Author

merged into all branches

@petebacondarwin
Copy link
Contributor

Fingers crossed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants