Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

doc Fix typo component.ngdoc #13890

Closed
wants to merge 1 commit into from
Closed

doc Fix typo component.ngdoc #13890

wants to merge 1 commit into from

Conversation

DrDanRyan
Copy link
Contributor

The wrong field name was being passed into the $ctrl.update call in heroDetail.html resulting in the wrong behavior (name was being updated instead of location)

@DrDanRyan
doc Fix typo component.ngdoc
f3927c4 
The wrong field name was being passed into the `$ctrl.update` call in `heroDetail.html` resulting in the wrong behavior (`name` was being updated instead of `location`)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@DrDanRyan
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz closed this in db1180f Jan 29, 2016
@DrDanRyan DrDanRyan deleted the patch-1 branch March 29, 2016 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrDanRyan @googlebot