This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix (ngResource) dynamic params escaping fix #15627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2017 20:12
Added replacing of '%5c' (url encoded backslash) with \ (backslash) in Angular.js Added tests for this behavior in resourceSpec.js No breaking changes
gkalpak
reviewed
Jan 26, 2017
| @@ -594,7 +594,7 @@ angular.module('ngResource', ['ng']). | |||
| // E.g. `http://url.com/id./format?q=x` becomes `http://url.com/id.format?q=x` | |||
| url = url.replace(/\/\.(?=\w+($|\?))/, '.'); | |||
| // replace escaped `/\.` with `/.` | |||
| config.url = protocolAndIpv6 + url.replace(/\/\\\./, '/.'); | |||
| config.url = protocolAndIpv6 + url.replace(/\/(\\|%5C)\./, '/.'); | |||
There was a problem hiding this comment.
Please, add a comment about how %5C came to be.
|
Regarding the breaking change, thinking about it again the only usecase that would fail is the following (which is very unlikely): $resource('/foo/:bar', {bar: '\\.baz'})
// Request URL before: /foo/%5C.baz
// Request URL after: /foo/.bazAnd considering that So, this is a fix 🎉 |
gkalpak
approved these changes
Jan 27, 2017
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
It doesn't work correctly according to docs if url params are dynamic. So, for instance, this is gonna work:
but almost the same code works incorrectly:
it sends request to
:path/%5C.jsonDoes this PR introduce a breaking change?
Might be
Please check if the PR fulfills these requirements
Other information: