From fbe34843e9f3bbbf800d3b6b68b0096eebbb5614 Mon Sep 17 00:00:00 2001 From: Vasili Svirydau Date: Mon, 22 Jul 2013 13:35:25 -0700 Subject: [PATCH] Under certain circumstances location.href is not defined in IE8. Which sometimes causes an infinite routing loop --- src/ng/browser.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ng/browser.js b/src/ng/browser.js index a723271b95ec..54cba1a35716 100644 --- a/src/ng/browser.js +++ b/src/ng/browser.js @@ -160,13 +160,14 @@ function Browser(window, document, $log, $sniffer) { } } else { if (replace) location.replace(url); - else location.href = url; + else if (location.href) location.href = url; + else location = url; } return self; // getter } else { // the replacement is a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=407172 - return location.href.replace(/%27/g,"'"); + return (location.href || location).replace(/%27/g,"'"); } };