feat(eslint-plugin-template): [click-events-have-key-events] Added ignoreWithDirectives option #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2025 11:43
|
View your CI Pipeline Execution ↗ for commit fbae881.
☁️ Nx Cloud last updated this comment at |
JamesHenry
requested changes
May 8, 2025
There was a problem hiding this comment.
Thanks for this @jelledijkstra97 please have a run through the commands with have in ci.yml and make sure they are all passing
|
@JamesHenry I updated the docs and the tests succeed on my machine now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
==========================================
+ Coverage 92.88% 92.89% +0.01%
==========================================
Files 197 197
Lines 4145 4154 +9
Branches 970 973 +3
==========================================
+ Hits 3850 3859 +9
Misses 227 227
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thanks again! |
igord
pushed a commit
to tcorral/angular-eslint
that referenced
this pull request
Jun 1, 2025
…noreWithDirectives option (angular-eslint#2365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ignoreWithDirective option to the click-events-have-key-events rule. See #1996