fix(eslint-plugin-template): [prefer-template-literal] handle parentheses in autofix #2418
+557
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 49342bb.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
+ Coverage 92.70% 92.72% +0.02%
==========================================
Files 195 195
Lines 4056 4071 +15
Branches 930 937 +7
==========================================
+ Hits 3760 3775 +15
Misses 228 228
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JamesHenry
approved these changes
May 13, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of autofix error cases
In some cases (when autofix result is a template), a parenthesis is removed but not both.
'prefix-' + (condition ? 'true' : 'false')=>`prefix-${condition ? 'true' : 'false'}`)('value' | pipe) + "-suffix"=>(`${'value' | pipe}-suffix`Fix
If node is surronded by parentheses remove them, with template literal they become useless