Skip to content

fix(eslint-plugin-template): [cyclomatic-complexity] handle new control flow syntax #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

fix(eslint-plugin-template): [cyclomatic-complexity] handle new control flow syntax #2447

merged 1 commit into from
May 24, 2025

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 24, 2025 •
edited
Loading

Fixes #2252

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b089b5d.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 19s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 46s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 1m 13s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 29s View ↗
nx run-many -t build ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-24 20:11:07 UTC

@codecov Codecov
Copy link

codecov bot commented May 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (44e57ec) to head (b089b5d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
+ Coverage   92.83%   92.84%   +0.01%     
==========================================
  Files         195      195              
  Lines        4073     4083      +10     
  Branches      945      951       +6     
==========================================
+ Hits         3781     3791      +10     
  Misses        225      225              
  Partials       67       67
Flag Coverage Δ
unittest 92.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plugin-template/src/rules/cyclomatic-complexity.ts 100.00% <100.00%> (ø)
...emplate/tests/rules/cyclomatic-complexity/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry changed the title fix(eslint-plugin-template): handle new control flow fix(eslint-plugin-template): [cyclomatic-complexity] handle new control flow syntax May 24, 2025
@JamesHenry JamesHenry marked this pull request as ready for review May 24, 2025 20:20
@JamesHenry JamesHenry merged commit 2844851 into main May 24, 2025
11 checks passed
@JamesHenry JamesHenry deleted the codex/fix-cyclomatic-complexity-rule-for-new-angular-control-flow branch May 24, 2025 20:23
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
@JamesHenry @igord
fix(eslint-plugin-template): [cyclomatic-complexity] handle new contr…
6ae2dce 
…ol flow syntax (angular-eslint#2447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/template/cyclomatic-complexity] Take into consideration new Angular control flows when calculating cyclomatic complexity
1 participant
@JamesHenry