Skip to content

feat(builder): add stats option #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2025
Merged

feat(builder): add stats option #2453

merged 4 commits into from
May 25, 2025

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 25, 2025 •
edited
Loading

Summary

  • expose --stats option in the lint builder schema
  • support stats in builder implementation and util
  • document the stats option
  • test stats option and stats output

Fixes #1370

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 49ed9be.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 36s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 33s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 31s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 5s View ↗
nx run-many -t build ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-25 09:44:22 UTC

JamesHenry
JamesHenry commented May 25, 2025
View reviewed changes
claude bot and others added 2 commits May 25, 2025 09:24
@claude @JamesHenry
fix(builder): remove duplicate stats key in test
30fe635 
Co-authored-by: JamesHenry <JamesHenry@users.noreply.github.com>
@JamesHenry
chore: fix tests
0c54c41
@JamesHenry JamesHenry marked this pull request as ready for review May 25, 2025 09:38
@codecov Codecov
Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (2ef4cb3) to head (49ed9be).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
- Coverage   92.84%   92.80%   -0.05%     
==========================================
  Files         195      195              
  Lines        4083     4088       +5     
  Branches      951      953       +2     
==========================================
+ Hits         3791     3794       +3     
- Misses        225      226       +1     
- Partials       67       68       +1
Flag Coverage Δ
unittest 92.80% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/builder/src/utils/eslint-utils.ts 76.47% <100.00%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry merged commit 5ce32d5 into main May 25, 2025
8 checks passed
@JamesHenry JamesHenry deleted the codex/add---stats-option-to-angular-eslint-builder branch May 25, 2025 09:48
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
@JamesHenry @igord
feat(builder): add stats option (angular-eslint#2453)
6816bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claude claude[bot] claude[bot] left review comments

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling eslint rules performance
1 participant
@JamesHenry