Skip to content

fix(eslint-plugin): [no-output-on-prefix] update style guide link #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 16, 2025
Merged

fix(eslint-plugin): [no-output-on-prefix] update style guide link #2514

merged 5 commits into from
Jun 16, 2025

Conversation

vsantele
Copy link
Contributor

There was a broken link for the rule @angular-eslint/no-output-on-prefix.

@vsantele vsantele changed the title Fix broken link for @angular-eslint/no-output-on-prefix rule chore: Fix broken link for @angular-eslint/no-output-on-prefix rule Jun 11, 2025
@JamesHenry
Copy link
Member

@vsantele Documentation is auto-generated from the rules, so the rule source needs to be updated and then the rule documentation regenerated with pnpm update-rule-docs.

@claude please update this PR to address that

@claude Claude
Copy link

claude bot commented Jun 16, 2025 •
edited
Loading

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@JamesHenry JamesHenry changed the title chore: Fix broken link for @angular-eslint/no-output-on-prefix rule fix(eslint-plugin): [no-output-on-prefix] update style guide link Jun 16, 2025
@JamesHenry
Copy link
Member

Oh Claude can't operate on your fork, please kindly do it yourself @vsantele

@vsantele
Copy link
Contributor Author

Oh I wasn't aware of that! It's good to know, I'll fix that later today (since Claude doesn't work for me ^^)

JamesHenry
JamesHenry requested changes Jun 16, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1e98bee.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 37s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 1m 2s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 37s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 42s View ↗
nx run-many -t build ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 15:01:35 UTC

@vsantele
Copy link
Contributor Author

I updated the link in the source code, then ran pnpm update-rule-docs. The result is the same as my previous commit. So the source code and documentation are synchronised.

I chose to make a direct link to the page where the angular doc talks about the event name, and not the part in the style guide which only redirects to the component/outputs docs.

@vsantele vsantele requested a review from JamesHenry June 16, 2025 11:20
@JamesHenry
Copy link
Member

Sorry forgot you need to update the rule lists for this kind of change too

@JamesHenry JamesHenry mentioned this pull request Jun 16, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (c3378d2) to head (1e98bee).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2514   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         207      207           
  Lines        4374     4374           
  Branches     1020     1020           
=======================================
  Hits         4059     4059           
  Misses        245      245           
  Partials       70       70
Flag Coverage Δ
unittest 92.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/eslint-plugin/src/rules/no-output-on-prefix.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JamesHenry
JamesHenry approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JamesHenry JamesHenry merged commit d1d1afb into angular-eslint:main Jun 16, 2025
9 checks passed
@vsantele vsantele deleted the patch-1 branch June 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsantele @JamesHenry