-
-
Notifications
You must be signed in to change notification settings - Fork 497
Keyboard support #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a good idea. How would you handle range sliders? |
Tabbing would select With some added aria roles and tab indices this sounds doable to me. One question is how to handle range slider and aria role, as it looks like the current spec does not accommodated for range sliders, and would involve a duplicate Do you see any difficulties in implementing this? |
Would love to have a crack at this (first fork and merge request it would be), but not sure when I'll get the time for it. |
Actually, I have never used aria roles so I can't tell you what I prefer. ^^ |
Cool! I'll wait hold the fork, and see what I can cook up. Looks like mye guess about aria and ranged slider was correct as well: http://oaa-accessibility.org/example/32/ |
Any feedback on #158 would be great ;) |
Do you know if there is another way than setting a tabindex to enable tabbing to an element? Because the tabindex will need to be customizable since we don't know were the slider can be included... If a user is already using tab index for a form and we set default ones for the slider, it can creates problem. [EDIT]: Actually, setting a value of 0 doesn't change the flow of the document but still enable to focus on an element. |
That's right, tabindex=0 would let it follow the normal flow. The only immediate challenge I see is that each slider dot should have an aria-describedby which would need a unique ID. Any thoughts on how to do that? Also, this describedby text should be customizable so that it can match any language, but I guess a default text value would be acceptable, simply stating “upper/lower”. |
alos, #158 looks neat! |
If there are two sliders on a page, does each pointer need a unique aria-describedby? |
any updates here? Are you guys looking to still add keyboard accessibility? |
On my side there is nothing done yet but I'll definitely work on it when I get some free time for this library. |
Awesome - I will try to get it done over the next few weeks - as a PR :) |
If you have the time, @georgebatalinski go ahead, I havent found the time yet to try it out. |
I am starting to work on - first setup, I want to setup some unit tests to understand the update flow. |
Are you working on a separate PR or looking at mine? |
I am on your PR now - #191 |
It's available with the 2.3.0 release |
It would be great if the slider could handle keyboard interaction as well, not to say an accessibility boost. Doesn't need to be any more complex than
tabindex
onrx-pointer
and arrow left/right increasing/decreasing the slider with the step value set.Thoughts?
The text was updated successfully, but these errors were encountered: