Skip to content

Changing the way to set label to increase customizability #355

Closed
@Liooo

Description

@Liooo

Problem

The library doesn't have capability to customize label using angular directive.

Solution

Exposing variables that store label strings on the template's scope, rather than setting with $.html()
Here's the quick simple code change.

and here's the jsfiddle.

i roughly looked through the code, and noticed i still need to fix the following things, in addition to the change above.

  1. the logic to recalcute the dimension
  2. use css display:hide rather than opacity:0 to hide combo label or model/high label as they switch, in case for example there's ng-click attached on either of the element (written here)
  3. leaving the backward compatibility (but probably we don't need translate option in the future if we're doing this)

Question

what do you guys think of this idea and the solution?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions