Skip to content

angularjs-slider displaying NaN and not working with jQuery 3.0.0 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozirissp opened this issue Jul 6, 2016 · 4 comments
Closed

angularjs-slider displaying NaN and not working with jQuery 3.0.0 #365

ozirissp opened this issue Jul 6, 2016 · 4 comments
Labels

Comments

@ozirissp
Copy link

ozirissp commented Jul 6, 2016

angularjs-slider is not working on mobile browser (or with chrome desktop in mobile mode: CTRL+SHIFT+I and CTRL+SHIFT+M) ...

Display NaN when trying to slide ... seems to be a touch event issue, because it's working with keyboard (but there is no JS error) ...

Actual problem is discribe with sample in this stackoverflow :
http://stackoverflow.com/questions/35758496/angular-js-touch-slider-displaying-nan-error-when-used-with-ionic-framework

Sample : https://jsfiddle.net/oziris_sp/t381ff52/
Updated : It's seems to be an side effect of using jQuery 3.0.0

Expected behaviour

Working without problem on mobile ...

Actual behaviour

Not working and display NaN when slided

@ValentinH
Copy link
Member

All sliders on the demo site work on mobile. Please provide the demo that doesn't work.

@ozirissp
Copy link
Author

ozirissp commented Jul 6, 2016

Here a jsfiddle : https://jsfiddle.net/oziris_sp/t381ff52/ , try it in mobile mode !

It's happen only with jQuery 3.0.0 ...

Here the same code (working) with jQuery 2.2.4 : https://jsfiddle.net/oziris_sp/t381ff52/3/

@ozirissp ozirissp changed the title angularjs-slider displaying NaN and not working ... angularjs-slider displaying NaN and not working with jQuery 3.0.0 Jul 6, 2016
@ValentinH
Copy link
Member

You are right! Touch events are broken with jQuery 3.0. This line is the culprit because in jQuery 3.0, they use proxy, so this way of testing undefined is incorrect.

I'm fixing it right away.

@ValentinH
Copy link
Member

Demo of fixed version: https://jsfiddle.net/p9aa2ub3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants