Skip to content

Spurious network call #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kwood-gmr opened this issue Dec 3, 2021 · 1 comment
Closed

Spurious network call #316

kwood-gmr opened this issue Dec 3, 2021 · 1 comment
Labels

Comments

@kwood-gmr
Copy link

Anytime there is a split area that is not resizable a single network call will be made back to the current location. Typically this will not be noticed as the web server then re-writes the call to the page origin and responds. My company is using this inside an Electron app and it results in a failed network call (that is benign, but there).

I have isolated this to the scss for the as-split component. As of writing this it is line 93. The lines affected are:
.as-split-gutter-icon {
background-image: url('');
}

I would be glad to provide a pull request to fix this which could be done by either:

  1. Replace the URL with a data url similar to the others including a single transparent pixel
  2. Remove the background image

Thanks for the great package.

@kwood-gmr kwood-gmr added the bug label Dec 3, 2021
rahuldimri added a commit to rahuldimri/angular-split that referenced this issue Jun 14, 2022
…t#316

Adding a transparent 1x1 background image so that no spurious network call is shown. Particularly reproducible in electron env's.
rahuldimri added a commit to rahuldimri/angular-split that referenced this issue Jun 14, 2022
…t#316

Adding a transparent 1x1 background image so that no spurious network call is shown. Particularly reproducible in electron env's.
beeman pushed a commit that referenced this issue Sep 11, 2022
Adding a transparent 1x1 background image so that no spurious network call is shown. Particularly reproducible in electron env's.
@beeman
Copy link
Collaborator

beeman commented Sep 11, 2022

This should be fixed by #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants