Skip to content

Switching from TSLint to ESLint #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jefiozie opened this issue Jan 21, 2024 · 1 comment · Fixed by #382
Closed

Switching from TSLint to ESLint #374

Jefiozie opened this issue Jan 21, 2024 · 1 comment · Fixed by #382
Labels
area: build & ci Related the build and CI infrastructure of the project enhancement

Comments

@Jefiozie
Copy link
Member

We need to update our Angular project by replacing TSLint with ESLint. TSLint is being phased out, and ESLint is now the preferred linter for TypeScript projects, including Angular.

Key actions for the switch:

  1. Remove TSLint: Uninstall TSLint and its related configurations.
  2. Install ESLint: Add ESLint to our project with Angular-specific configurations.
  3. Use Angular CLI command: ng add @angular-eslint/schematics.
  4. Configure ESLint Rules: Set up a new .eslintrc.json file tailored for our Angular project.
  5. Update Build Scripts: Ensure ESLint checks are part of our build and test scripts.
  6. Fix Existing Code: Run ESLint to identify and fix any linting issues in our current code.
  7. Documentation Update: Briefly explain the change in our README or contribution guidelines.

This update will keep our project aligned with the latest Angular standards and improve code quality.
@Jefiozie Jefiozie added enhancement area: build & ci Related the build and CI infrastructure of the project labels Jan 21, 2024
@Jefiozie
Copy link
Member Author

We should add the lint rule explicit-member-accessibillity to make sure that we don't reference any public keywords anymore.

See #354 (comment)

@Jefiozie Jefiozie mentioned this issue Jan 23, 2024
Merged
Jefiozie added a commit that referenced this issue Jan 23, 2024
@Jefiozie
feat: introduce eslint and remove tslint closes (#374) (#382)
b8431f4 
* feat: introduce eslint to the project

* fix: resolve linting rules

* fix: resolve linting rules for app and exclude nx

* fix: resolve linting rules for app

* fix: resolve type issues

* feat: introduce explicit member rule

* chore: update git hook to run lint commiting

* chore: set husky as a prepare step so that hook will be handled
This was referenced Jan 24, 2024
Closed
Merged
@github-actions github-actions bot mentioned this issue Feb 26, 2024
Closed
@github-actions github-actions bot mentioned this issue May 2, 2024
Closed
@fjaguado fjaguado mentioned this issue Jul 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Oct 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce eslint and remove tslint closes (#374) Jefiozie/angular-split
1 participant
@Jefiozie