Skip to content

Transition to Angular Standalone Components in Favor of Angular Modules #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jefiozie opened this issue Jan 21, 2024 · 3 comments · Fixed by #444
Closed

Transition to Angular Standalone Components in Favor of Angular Modules #378

Jefiozie opened this issue Jan 21, 2024 · 3 comments · Fixed by #444
Labels
area: core Relates to the library project breaking changes enhancement

Comments

@Jefiozie
Copy link
Member

To align with modern Angular development practices, we propose migrating our project to use Angular Standalone Components. This transition aims to simplify our application architecture, improve modularity, and enhance developer experience.

@Jefiozie Jefiozie added enhancement breaking changes area: core Relates to the library project labels Jan 21, 2024
@Harpush
Copy link
Collaborator

Harpush commented Jan 21, 2024

As a non breaking change first phase - we can transition to standalone but remain with an exported module importing and re-exporting the standalone components/directives.

One other concern is we currently have multiple directives and components that are needed for the split to function. How will end users import those in a "bundle"? If I remember correctly exporting a const array still doesn't work from libraries.

@Jefiozie
Copy link
Member Author

I agree on the fact that we can easily do both for the current version. And when we bump to a major version remove the module.

About the question, yes there is a problem with the import of standalone CMP /directives with an array. But there is also a workaround, we can use the spread operator to still import them. There is an ongoing issue that will fix the array without a spread operator.

@Harpush
Copy link
Collaborator

Harpush commented Apr 29, 2024

Just adding that we should introduce provideAngularSplit or provideAngularSplitOptions to allow using ANGULAR_SPLIT_DEFAULT_OPTIONS easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Relates to the library project breaking changes enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants