Skip to content

fix: spurious network call due to empty background image #316 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2022
Merged

fix: spurious network call due to empty background image #316 #322

merged 1 commit into from
Sep 11, 2022

Conversation

rahuldimri
Copy link
Contributor

Adding a transparent 1x1 background image so that no spurious network call is shown. Particularly reproducible in electron env's.

@rahuldimri
fix: spurious network call due to empty background image angular-spli…
6bfad23 
…t#316

Adding a transparent 1x1 background image so that no spurious network call is shown. Particularly reproducible in electron env's.
@rahuldimri
Copy link
Contributor Author

@bertrandg Can you please review?

@beeman
Copy link
Collaborator

beeman commented Jul 19, 2022

@bertrandg Can you please review?

Hi @rahuldimri, thanks for your contribution. Betrand is no longer involved with this project. I will review and release it once I get confirmation that the v14 release is working as expected!

@rahuldimri
Copy link
Contributor Author

Sure thanks @beeman

@rahuldimri
Copy link
Contributor Author

@beeman Did you get a chance to look into this request?.

@rahuldimri
Copy link
Contributor Author

@beeman any idea when are we going to merge this PR request.

@beeman beeman merged commit cf0f2d0 into angular-split:main Sep 11, 2022
@beeman beeman mentioned this pull request Sep 11, 2022
Closed
@beeman
Copy link
Collaborator

beeman commented Sep 11, 2022

Thanks for your contribution @rahuldimri, it's released as angular-split@14.1.0

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Closed
@Jefiozie
Copy link
Member

@all-contributors please add @rahuldimri for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Jan 24, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@Jefiozie

I've put up a pull request to add @rahuldimri! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Merged
@fjaguado fjaguado mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahuldimri @beeman @Jefiozie