Skip to content

Commit 90cc8f4

Browse files
committed
fix types
1 parent d9df524 commit 90cc8f4

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

libs/core/src/lib/three-types.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
ArrowHelper,
55
Audio,
66
AxesHelper,
7+
BatchedMesh,
78
Bone,
89
Box3Helper,
910
BoxGeometry,
@@ -195,7 +196,9 @@ export type NgtNode<TOriginal, TConstructor, TNoEvent = NoEvent<TOriginal>> = Ex
195196

196197
export type NgtObject3DEventsMap = {
197198
[TEvent in keyof NgtEventHandlers]-?: Parameters<NonNullable<NgtEventHandlers[TEvent]>>[0];
198-
} & NgtNodeEventMap<NgtInstanceNode>;
199+
};
200+
201+
export type NgtAllObject3DEventsMap = NgtObject3DEventsMap & NgtNodeEventMap<NgtInstanceNode>;
199202

200203
export type NgtObject3DNode<TOriginal, TConstructor, TNoEvent = NoEvent<TOriginal>> = Expand<
201204
NgtOverwrite<
@@ -209,13 +212,13 @@ export type NgtObject3DNode<TOriginal, TConstructor, TNoEvent = NoEvent<TOrigina
209212
quaternion: NgtQuaternion;
210213
layers: NgtLayers;
211214
dispose: (() => void) | null;
212-
addEventListener<TEventKey extends keyof NgtObject3DEventsMap>(
215+
addEventListener<TEventKey extends keyof NgtAllObject3DEventsMap>(
213216
type: TEventKey,
214-
listener: (this: NgtObject3DNode<TOriginal, TConstructor>, ev: NgtObject3DEventsMap[TEventKey]) => any,
217+
listener: (this: NgtObject3DNode<TOriginal, TConstructor>, ev: NgtAllObject3DEventsMap[TEventKey]) => any,
215218
): void;
216-
removeEventListener<TEventKey extends keyof NgtObject3DEventsMap>(
219+
removeEventListener<TEventKey extends keyof NgtAllObject3DEventsMap>(
217220
type: TEventKey,
218-
listener: (this: NgtObject3DNode<TOriginal, TConstructor>, ev: NgtObject3DEventsMap[TEventKey]) => any,
221+
listener: (this: NgtObject3DNode<TOriginal, TConstructor>, ev: NgtAllObject3DEventsMap[TEventKey]) => any,
219222
): void;
220223
}
221224
>
@@ -232,6 +235,7 @@ export type NgtPositionalAudio = NgtObject3DNode<PositionalAudio, typeof Positio
232235

233236
export type NgtMesh = NgtObject3DNode<Mesh, typeof Mesh>;
234237
export type NgtInstancedMesh = NgtObject3DNode<InstancedMesh, typeof InstancedMesh>;
238+
export type NgtBatchedMesh = NgtObject3DNode<BatchedMesh, typeof BatchedMesh>;
235239
export type NgtScene = NgtObject3DNode<Scene, typeof Scene>;
236240
export type NgtSprite = NgtObject3DNode<Sprite, typeof Sprite>;
237241
export type NgtLOD = NgtObject3DNode<LOD, typeof LOD>;

0 commit comments

Comments
 (0)