Correction to dependencies and error checking

pkozlowski-opensource · pkozlowski-opensource · commit b597646bf688 · 2012-08-04T12:20:28.000+02:00
diff --git a/modules/directives/validate/validate.js b/modules/directives/validate/validate.js
@@ -10,7 +10,7 @@
  * @param ui-validate {string} The name of a function to be used as a validator. The function will get a value to be
  * validates as its argument and should return true/false indicating a validation result.
  */
-angular.module('ui.directives').directive('uiValidate', function ($parse) {
+angular.module('ui.directives').directive('uiValidate', function () {
 
   return {
     restrict:'A',
@@ -22,8 +22,8 @@ angular.module('ui.directives').directive('uiValidate', function ($parse) {
         return;
       }
 
-      if (!angular.isFunction(scope[validateExpr])){
-        throw Error('uiValidate expression "'+validateExpr+'" is not a function.');
+      if (!angular.isFunction(scope[validateExpr])) {
+        throw Error('uiValidate expression "' + validateExpr + '" is not a function.');
       }
 
       var validateFn = function (valueToValidate) {
@@ -39,10 +39,8 @@ angular.module('ui.directives').directive('uiValidate', function ($parse) {
         }
       };
 
-      if (ctrl) {
-        ctrl.$formatters.push(validateFn);
-        ctrl.$parsers.push(validateFn);
-      }
+      ctrl.$formatters.push(validateFn);
+      ctrl.$parsers.push(validateFn);
     }
   }
 });

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* @param ui-validate {string} The name of a function to be used as a validator. The function will get a value to be`
`11`	`11`	`* validates as its argument and should return true/false indicating a validation result.`
`12`	`12`	`*/`
`13`		`-angular.module('ui.directives').directive('uiValidate', function ($parse) {`
	`13`	`+angular.module('ui.directives').directive('uiValidate', function () {`
`14`	`14`
`15`	`15`	`return {`
`16`	`16`	`restrict:'A',`
`@@ -22,8 +22,8 @@ angular.module('ui.directives').directive('uiValidate', function ($parse) {`
`22`	`22`	`return;`
`23`	`23`	`}`
`24`	`24`
`25`		`- if (!angular.isFunction(scope[validateExpr])){`
`26`		`- throw Error('uiValidate expression "'+validateExpr+'" is not a function.');`
	`25`	`+ if (!angular.isFunction(scope[validateExpr])) {`
	`26`	`+ throw Error('uiValidate expression "' + validateExpr + '" is not a function.');`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`var validateFn = function (valueToValidate) {`
`@@ -39,10 +39,8 @@ angular.module('ui.directives').directive('uiValidate', function ($parse) {`
`39`	`39`	`}`
`40`	`40`	`};`
`41`	`41`
`42`		`- if (ctrl) {`
`43`		`- ctrl.$formatters.push(validateFn);`
`44`		`- ctrl.$parsers.push(validateFn);`
`45`		`- }`
	`42`	`+ ctrl.$formatters.push(validateFn);`
	`43`	`+ ctrl.$parsers.push(validateFn);`
`46`	`44`	`}`
`47`	`45`	`}`
`48`	`46`	`});`