Skip to content

Commit 052e148

Browse files
authored
fix(datascienceonramp): revert workaround (GoogleCloudPlatform#5533)
## Description Fixes GoogleCloudPlatform#5421 Note: It's a good idea to open an issue first for discussion. ## Checklist - [x] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md) - [x] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file) - [x] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [x] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [x] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample
1 parent 1b406ba commit 052e148

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

data-science-onramp/data-cleaning/clean_test.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@
6969
"pyspark_job": {
7070
"main_python_file_uri": f"gs://{BUCKET_NAME}/{BUCKET_BLOB}",
7171
"args": [BUCKET_NAME, BQ_TABLE, "--dry-run"],
72-
# Temporarily pin jar version due to breaking release
73-
# "jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-latest_2.12.jar"],
74-
"jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-with-dependencies_2.12-0.18.1.jar"],
72+
"jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-latest_2.12.jar"],
7573
},
7674
}
7775

data-science-onramp/data-ingestion/setup_test.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@
6767
"pyspark_job": {
6868
"main_python_file_uri": f"gs://{BUCKET_NAME}/{BUCKET_BLOB}",
6969
"args": [BUCKET_NAME, BQ_DATASET, "--test"],
70-
# Temporarily pin jar version due to breaking release
71-
# "jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-latest_2.12.jar"],
72-
"jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-with-dependencies_2.12-0.18.1.jar"],
70+
"jar_file_uris": ["gs://spark-lib/bigquery/spark-bigquery-latest_2.12.jar"],
7371
},
7472
}
7573

0 commit comments

Comments
 (0)