fix: promise error handler

周琳 · 周琳 · commit 9a2645535201 · 2019-04-24T20:24:51.000+08:00
diff --git a/index.js b/index.js
@@ -74,7 +74,10 @@ function aopPromise(commit, loading, fn) {
   }
   return (...arg) => {
     let promise = Promise.resolve(loading)
-    let chain = [showLoading, undefined, fn.bind(null, ...arg), undefined, hideLoading, hideLoading]
+    let chain = [showLoading, undefined, fn.bind(null, ...arg), undefined, hideLoading, function (error) {
+      hideLoading()
+      return Promise.reject(error)
+    }]
     while (chain.length > 0) {
       promise = promise.then(chain.shift(), chain.shift())
     }
diff --git a/lib/vuex-loading.js b/lib/vuex-loading.js
@@ -108,7 +108,10 @@ function aopPromise(commit, loading, fn) {
     }
 
     var promise = Promise.resolve(loading);
-    var chain = [showLoading, undefined, fn.bind.apply(fn, [null].concat(arg)), undefined, hideLoading, hideLoading];
+    var chain = [showLoading, undefined, fn.bind.apply(fn, [null].concat(arg)), undefined, hideLoading, function (error) {
+      hideLoading();
+      return Promise.reject(error);
+    }];
     while (chain.length > 0) {
       promise = promise.then(chain.shift(), chain.shift());
     }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,10 @@ function aopPromise(commit, loading, fn) {`
`74`	`74`	`}`
`75`	`75`	`return (...arg) => {`
`76`	`76`	`let promise = Promise.resolve(loading)`
`77`		`- let chain = [showLoading, undefined, fn.bind(null, ...arg), undefined, hideLoading, hideLoading]`
	`77`	`+ let chain = [showLoading, undefined, fn.bind(null, ...arg), undefined, hideLoading, function (error) {`
	`78`	`+ hideLoading()`
	`79`	`+ return Promise.reject(error)`
	`80`	`+ }]`
`78`	`81`	`while (chain.length > 0) {`
`79`	`82`	`promise = promise.then(chain.shift(), chain.shift())`
`80`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,10 @@ function aopPromise(commit, loading, fn) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`var promise = Promise.resolve(loading);`
`111`		`- var chain = [showLoading, undefined, fn.bind.apply(fn, [null].concat(arg)), undefined, hideLoading, hideLoading];`
	`111`	`+ var chain = [showLoading, undefined, fn.bind.apply(fn, [null].concat(arg)), undefined, hideLoading, function (error) {`
	`112`	`+ hideLoading();`
	`113`	`+ return Promise.reject(error);`
	`114`	`+ }];`
`112`	`115`	`while (chain.length > 0) {`
`113`	`116`	`promise = promise.then(chain.shift(), chain.shift());`
`114`	`117`	`}`