Skip to content

Restrict google-api-core #22481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2022
Merged

Restrict google-api-core #22481

merged 2 commits into from
Jul 27, 2022

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Jul 27, 2022 •
edited
Loading

Fixes #22454.

google-cloud-spanner==1.x implicitly require google-api-core <2.8.2. Most likely, this is because since google-api-core==2.8.2 drops support for grpcio-gcp: googleapis/python-api-core#401, which is used by google-cloud-spanner.

Also, regenerated container dependencies.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@tvalentyn
Copy link
Contributor Author

Run Python 3.7 PostCommit

@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #22481 (1adab38) into master (df5cdc8) will not change coverage.
The diff coverage is n/a.

❗ Current head 1adab38 differs from pull request most recent head d7395ab. Consider uploading reports for the commit d7395ab to get more accurate results

@@           Coverage Diff           @@
##           master   #22481   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files         706      706           
  Lines       93226    93226           
=======================================
  Hits        69154    69154           
  Misses      22804    22804           
  Partials     1268     1268
Flag Coverage Δ
python 83.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (-1.00%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 52.88% <0.00%> (-0.49%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 70.15% <0.00%> (-0.22%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tvalentyn
Copy link
Contributor Author

R: @BjornPrime cc: @parthea

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor Author

Noting that postcommit passed: https://ci-beam.apache.org/job/beam_PostCommit_Python37_PR/384/

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jul 27, 2022 •
edited
Loading

also R: @kileys (next release manager) - I think you would need main commit and the commit updating container requirements on the release branch.

@tvalentyn tvalentyn mentioned this pull request Jul 27, 2022
Merged
4 tasks
@tvalentyn
Copy link
Contributor Author

Docker precommit also passed, https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Commit/12107. all other test suites passed on previous commit and are not affected by requirements change (second commit). merging.

@tvalentyn tvalentyn merged commit 505b5b7 into apache:master Jul 27, 2022
@tvalentyn tvalentyn deleted the spannerio branch July 27, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kileys kileys kileys approved these changes

Assignees
No one assigned
Labels
docker python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Spanner ITs are failing in Py37 PostCommits
2 participants
@tvalentyn @kileys