-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Restrict google-api-core #22481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict google-api-core #22481
Conversation
Run Python 3.7 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #22481 +/- ##
=======================================
Coverage 74.17% 74.17%
=======================================
Files 706 706
Lines 93226 93226
=======================================
Hits 69154 69154
Misses 22804 22804
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
R: @BjornPrime cc: @parthea |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Noting that postcommit passed: https://ci-beam.apache.org/job/beam_PostCommit_Python37_PR/384/ |
also R: @kileys (next release manager) - I think you would need main commit and the commit updating container requirements on the release branch. |
Docker precommit also passed, https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Commit/12107. all other test suites passed on previous commit and are not affected by requirements change (second commit). merging. |
Fixes #22454.
google-cloud-spanner==1.x
implicitly requiregoogle-api-core <2.8.2
. Most likely, this is because since google-api-core==2.8.2 drops support for grpcio-gcp: googleapis/python-api-core#401, which is used by google-cloud-spanner.Also, regenerated container dependencies.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.