[SPARK-11864] [SQL] Improve performance of max/min #9846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 19, 2015 13:38
This reverts commit 3a23581.
|
LGTM |
|
Test build #46358 has finished for PR 9846 at commit
|
|
Test build #46362 has finished for PR 9846 at commit
|
|
Thanks - merging this. |
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2015
This PR has the following optimization: 1) The greatest/least already does the null-check, so the `If` and `IsNull` are not necessary. 2) In greatest/least, it should initialize the result using the first child (removing one block). 3) For primitive types, the generated greater expression is too complicated (`a > b ? 1 : (a < b) ? -1 : 0) > 0`), should be as simple as `a > b` Combine these optimization, this could improve the performance of `ss_max` query by 30%. Author: Davies Liu <davies@databricks.com> Closes #9846 from davies/improve_max. (cherry picked from commit ee21407) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following optimization:
The greatest/least already does the null-check, so the
IfandIsNullare not necessary.In greatest/least, it should initialize the result using the first child (removing one block).
For primitive types, the generated greater expression is too complicated (
a > b ? 1 : (a < b) ? -1 : 0) > 0), should be as simple asa > bCombine these optimization, this could improve the performance of
ss_maxquery by 30%.