Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.1
Choose a base ref
...
head repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.2
Choose a head ref
  • 4 commits
  • 5 files changed
  • 3 contributors

Commits on Mar 11, 2024

  1. Update CI to use release 5.10 image (#47)

    @glbrntt
    glbrntt authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f81270e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Remove unnecessary self keyword (#48) 

    ### Motivation

- We want to avoid redundant code by removing unnecessary self keywords

### Modifications

- Removed unnecessary self keywords

### Result

- No errors, `./scripts/soundness.sh` also passed.
- Follow [this
reference](https://github.com/apple/swift-openapi-urlsession/blob/main/CONTRIBUTING.md#run-scriptssoundnesssh)
    @Nao-RandD
    Nao-RandD authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6b915d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Fix request and response translation (#51)

    @guoye-zhang
    guoye-zhang authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    50e1f4a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Change 'unsafeDowncast' to 'as!' (#52) 

    Motivation:

The 'unsafeDowncast' can cause a miscompile leading to unexpected
runtime behaviour.

Modifications:

- Use 'as!' instead

Result:

No miscompiles on 5.10
    @glbrntt
    glbrntt authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9bf4c71 View commit details
    Browse the repository at this point in the history
Loading