-
Notifications
You must be signed in to change notification settings - Fork 852
Refactor RestHandler state machine into a coroutine #21787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
goedderz
wants to merge
44
commits into
devel
Choose a base branch
from
feature/refactor-resthandler-state-machine-into-coro
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor RestHandler state machine into a coroutine #21787
goedderz
wants to merge
44
commits into
devel
from
feature/refactor-resthandler-state-machine-into-coro
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor-resthandler-state-machine-into-coro
- Temporarily disabled LogContext (ScopedValue in rest handler state machine) - Made more stuff async - Fixed an issue by moving a coro from Future to async, because futures don't pass ExecContext as coros (just as an awaitable) - Fixed an issue by moving WAITING<->coro adapter further up the stack
…actor-resthandler-state-machine-into-coro
…e+waitForFuture The following handlers are changed: - RestAgencyHandler - RestAdminLogHandler - RestDocumentHandler - RestGraphHandler - RestImportHandler - RestLogHandler - RestLogInternalHandler - RestMetricsHandler - RestReplicationHandler - RestTransactionHandler - RestUsageMetricsHandler
…cute+waitForFuture
…actor-rest-handlers-into-coroutines
…actor-resthandler-state-machine-into-coro
…ub.com:arangodb/arangodb into feature/refactor-resthandler-state-machine-into-coro
…actor-resthandler-state-machine-into-coro
…rangodb_devel2 into feature/refactor-resthandler-state-machine-into-coro
…actor-resthandler-state-machine-into-coro
…actor-resthandler-state-machine-into-coro
…tely, not lazily, to prevent data races
This reverts commit 976cc74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Refactor the RestHandler's state machine into a coroutine. This is foundational work to allow rewriting more code into (asynchronous) coroutines.
Checklist