change cursor API from PUT to POST

jsteemann · jsteemann · commit 6cb22b17dbbd · 2021-04-22T20:38:49.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,10 @@ error message string "precondition failed". This was changed in version 3.7 to r
 same error codes, but an error message string of "conflict". Version 3.8 changes this again
 so the error message string is now "conflict, _rev values do not match".
 
+The `Cursor` class will now fetch outstanding cursor result data via HTTP POST requests to
+`/_api/cursor/<cursor-id>`. It previously fetched further results via HTTP PUT requests from
+the same address. The change is necessary because fetching further results is not an 
+idempotent operation, but the HTTP standard requires PUT operations to be idempotent.
 
 ## Release notes for the ArangoDB-PHP driver 3.7.x
 
diff --git a/lib/ArangoDBClient/Cursor.php b/lib/ArangoDBClient/Cursor.php
@@ -690,7 +690,7 @@ private function sanitize(array $rows)
     private function fetchOutstanding()
     {
         // continuation
-        $response = $this->_connection->put($this->url() . '/' . $this->_id, '', []);
+        $response = $this->_connection->post($this->url() . '/' . $this->_id, '', []);
         ++$this->_fetches;
 
         $data = $response->getJson();

Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,7 @@ private function sanitize(array $rows)`
`690`	`690`	`private function fetchOutstanding()`
`691`	`691`	`{`
`692`	`692`	`// continuation`
`693`		`- $response = $this->_connection->put($this->url() . '/' . $this->_id, '', []);`
	`693`	`+ $response = $this->_connection->post($this->url() . '/' . $this->_id, '', []);`
`694`	`694`	`++$this->_fetches;`
`695`	`695`
`696`	`696`	`$data = $response->getJson();`