From dd01e5ad03a00a14771a700646d948b4b14d383d Mon Sep 17 00:00:00 2001 From: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com> Date: Mon, 20 Feb 2023 10:38:13 +0100 Subject: [PATCH 1/7] Updated board names Updated some board names to the proper spelling @facchinm --- boards.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boards.txt b/boards.txt index c100ecc7b..b9add104a 100644 --- a/boards.txt +++ b/boards.txt @@ -58,7 +58,7 @@ yun.build.extra_flags={build.usb_flags} ############################################################## -uno.name=Arduino Uno +uno.name=Arduino UNO uno.vid.0=0x2341 uno.pid.0=0x0043 @@ -107,7 +107,7 @@ uno.build.variant=standard ############################################################## -unomini.name=Arduino Uno Mini +unomini.name=Arduino UNO Mini unomini.vid.0=0x2341 unomini.pid.0=0x0062 @@ -1272,7 +1272,7 @@ one.build.extra_flags={build.usb_flags} ############################################################## -unowifi.name=Arduino Uno WiFi +unowifi.name=Arduino UNO WiFi unowifi.vid.0=0x2A03 unowifi.pid.0=0x0057 unowifi.upload_port.0.vid=0x2A03 From daf2713c794c3019b44e74b949c7e050fd0339fd Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 18 Mar 2023 15:39:37 -0700 Subject: [PATCH 2/7] Correct misspelled word in comment This misspelled (mislocalized?) word was causing the spell check to fail --- libraries/Wire/examples/i2c_scanner/i2c_scanner.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/Wire/examples/i2c_scanner/i2c_scanner.ino b/libraries/Wire/examples/i2c_scanner/i2c_scanner.ino index 295edf7ef..508de805d 100644 --- a/libraries/Wire/examples/i2c_scanner/i2c_scanner.ino +++ b/libraries/Wire/examples/i2c_scanner/i2c_scanner.ino @@ -6,7 +6,7 @@ // can be found in many places. // For example on the Arduino.cc forum. // The original author is not known. -// Version 2, Juni 2012, Using Arduino 1.0.1 +// Version 2, June 2012, Using Arduino 1.0.1 // Adapted to be as simple as possible by Arduino.cc user Krodal // Version 3, Feb 26 2013 // V3 by louarnold From edb06d48c2cce3db6adcdd460df54cd0deb95aa1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Sep 2023 18:08:58 +0000 Subject: [PATCH 3/7] Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/check-arduino.yml | 2 +- .github/workflows/compile-platform-examples.yml | 2 +- .github/workflows/spell-check.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-arduino.yml b/.github/workflows/check-arduino.yml index 95f61d8fc..2c2d5f101 100644 --- a/.github/workflows/check-arduino.yml +++ b/.github/workflows/check-arduino.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Arduino Lint uses: arduino/arduino-lint-action@v1 diff --git a/.github/workflows/compile-platform-examples.yml b/.github/workflows/compile-platform-examples.yml index fad8e1d3d..d01f27688 100644 --- a/.github/workflows/compile-platform-examples.yml +++ b/.github/workflows/compile-platform-examples.yml @@ -176,7 +176,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Compile examples uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 3f6b03fb3..ef7d89414 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Spell check uses: codespell-project/actions-codespell@master From bd473a8fde47c10e7f38b48248440f918cf79eae Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 25 May 2024 01:45:57 -0700 Subject: [PATCH 4/7] Fix spell check false positives by ignoring words The codespell spellchecker tool is used to automatically detect commonly misspelled words in the files of this project. The misspelled words dictionary was expanded in the latest release of codespell. Some of the text in the project codebase happens to match against newly added entries, which caused codespell to produce false misspelled word detections. Since the code that produced the detections is correct and intended, the false positives are resolved by configuring codespell to ignore the problematic words. --- .codespellrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codespellrc b/.codespellrc index 825e4a0a2..7d9fef573 100644 --- a/.codespellrc +++ b/.codespellrc @@ -1,7 +1,7 @@ # See: https://github.com/codespell-project/codespell#using-a-config-file [codespell] # In the event of a false positive, add the problematic word, in all lowercase, to a comma-separated list here: -ignore-words-list = clen,hart,pullrequest +ignore-words-list = clearin,clen,hart,pullrequest,shiftin,waitin builtin = clear check-filenames = check-hidden = From 106b2c6372d9db5a17d19a06ccbd19407739b300 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 9 Oct 2024 08:37:11 +0000 Subject: [PATCH 5/7] Bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/compile-platform-examples.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/compile-platform-examples.yml b/.github/workflows/compile-platform-examples.yml index d01f27688..93e40a506 100644 --- a/.github/workflows/compile-platform-examples.yml +++ b/.github/workflows/compile-platform-examples.yml @@ -202,7 +202,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} From 6e6036eac13e1f06197c1e3f8e0dd7cfb9bc76f8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 9 Oct 2024 18:55:52 +0000 Subject: [PATCH 6/7] Bump arduino/arduino-lint-action from 1 to 2 Bumps [arduino/arduino-lint-action](https://github.com/arduino/arduino-lint-action) from 1 to 2. - [Release notes](https://github.com/arduino/arduino-lint-action/releases) - [Commits](https://github.com/arduino/arduino-lint-action/compare/v1...v2) --- updated-dependencies: - dependency-name: arduino/arduino-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/check-arduino.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-arduino.yml b/.github/workflows/check-arduino.yml index 2c2d5f101..3991385f1 100644 --- a/.github/workflows/check-arduino.yml +++ b/.github/workflows/check-arduino.yml @@ -19,7 +19,7 @@ jobs: uses: actions/checkout@v4 - name: Arduino Lint - uses: arduino/arduino-lint-action@v1 + uses: arduino/arduino-lint-action@v2 with: compliance: specification # Always use this setting for official repositories. Remove for 3rd party projects. From 8e9f84815111753b7206c9d1bfd2ffd94c1560dd Mon Sep 17 00:00:00 2001 From: per1234 Date: Fri, 18 Oct 2024 06:47:25 -0700 Subject: [PATCH 7/7] Don't upload multiple times to same artifact in sketch compilation workflow The "Compile Examples" GitHub Actions workflow is configured to compile the example sketches for each of the supported boards. This is done by using a job matrix in the GitHub Actions workflow to generate a parallel job for each board. A GitHub Actions workflow artifact is used to transfer the sketches report files generated by the "arduino/compile-sketches" action between this workflow's job and the "Report Size Deltas" workflow that uses the "arduino/report-size-deltas" action to publish the data. The "actions/upload-artifact" action is used to upload the sketches report files to the workflow artifact. Previously, the sketches reports from all the boards were uploaded to a single artifact. However, support for uploading multiple times to a single artifact was dropped in version 4.0.0 of the "actions/upload-artifact" action. So it is now necessary for each of the jobs to use a separate artifact. The "arduino/report-size-deltas" action is configured to recognize these multiple artifacts by a regular expression that matches against a standardized prefix on the artifact names. --- .../workflows/compile-platform-examples.yml | 40 ++++++++++++++++++- .github/workflows/report-size-deltas.yml | 4 +- 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/.github/workflows/compile-platform-examples.yml b/.github/workflows/compile-platform-examples.yml index 93e40a506..58cfd3409 100644 --- a/.github/workflows/compile-platform-examples.yml +++ b/.github/workflows/compile-platform-examples.yml @@ -35,117 +35,155 @@ jobs: matrix: board: - fqbn: arduino:avr:yun + artifact-name-suffix: arduino-avr-yun serial: true softwareserial: true - fqbn: arduino:avr:uno + artifact-name-suffix: arduino-avr-uno serial: true softwareserial: true - fqbn: arduino:avr:diecimila:cpu=atmega328 + artifact-name-suffix: arduino-avr-diecimila-cpu-atmega328 serial: true softwareserial: true - fqbn: arduino:avr:diecimila:cpu=atmega168 + artifact-name-suffix: arduino-avr-diecimila-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:nano:cpu=atmega328 + artifact-name-suffix: arduino-avr-nano-cpu-atmega328 serial: true softwareserial: true - fqbn: arduino:avr:nano:cpu=atmega328old + artifact-name-suffix: arduino-avr-nano-cpu-atmega328old serial: true softwareserial: true - fqbn: arduino:avr:nano:cpu=atmega168 + artifact-name-suffix: arduino-avr-nano-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:mega:cpu=atmega2560 + artifact-name-suffix: arduino-avr-mega-cpu-atmega2560 serial: true softwareserial: true - fqbn: arduino:avr:mega:cpu=atmega1280 + artifact-name-suffix: arduino-avr-mega-cpu-atmega1280 serial: true softwareserial: true - fqbn: arduino:avr:megaADK + artifact-name-suffix: arduino-avr-megaADK serial: true softwareserial: true - fqbn: arduino:avr:leonardo + artifact-name-suffix: arduino-avr-leonardo serial: true softwareserial: true - fqbn: arduino:avr:leonardoeth + artifact-name-suffix: arduino-avr-leonardoeth serial: true softwareserial: true - fqbn: arduino:avr:micro + artifact-name-suffix: arduino-avr-micro serial: true softwareserial: true - fqbn: arduino:avr:esplora + artifact-name-suffix: arduino-avr-esplora serial: true softwareserial: true - fqbn: arduino:avr:mini:cpu=atmega328 + artifact-name-suffix: arduino-avr-mini-cpu-atmega328 serial: true softwareserial: true - fqbn: arduino:avr:mini:cpu=atmega168 + artifact-name-suffix: arduino-avr-mini-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:ethernet + artifact-name-suffix: arduino-avr-ethernet serial: true softwareserial: true - fqbn: arduino:avr:fio + artifact-name-suffix: arduino-avr-fio serial: true softwareserial: true - fqbn: arduino:avr:bt:cpu=atmega328 + artifact-name-suffix: arduino-avr-bt-cpu-atmega328 serial: true softwareserial: true - fqbn: arduino:avr:bt:cpu=atmega168 + artifact-name-suffix: arduino-avr-bt-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:LilyPadUSB + artifact-name-suffix: arduino-avr-LilyPadUSB serial: true softwareserial: true - fqbn: arduino:avr:lilypad:cpu=atmega328 + artifact-name-suffix: arduino-avr-lilypad-cpu-atmega328 serial: true softwareserial: true - fqbn: arduino:avr:lilypad:cpu=atmega168 + artifact-name-suffix: arduino-avr-lilypad-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:pro:cpu=16MHzatmega328 + artifact-name-suffix: arduino-avr-pro-cpu-16MHzatmega328 serial: true softwareserial: true - fqbn: arduino:avr:pro:cpu=8MHzatmega328 + artifact-name-suffix: arduino-avr-pro-cpu-8MHzatmega328 serial: true softwareserial: true - fqbn: arduino:avr:pro:cpu=16MHzatmega168 + artifact-name-suffix: arduino-avr-pro-cpu-16MHzatmega168 serial: true softwareserial: true - fqbn: arduino:avr:pro:cpu=8MHzatmega168 + artifact-name-suffix: arduino-avr-pro-cpu-8MHzatmega168 serial: true softwareserial: true - fqbn: arduino:avr:atmegang:cpu=atmega168 + artifact-name-suffix: arduino-avr-atmegang-cpu-atmega168 serial: true softwareserial: true - fqbn: arduino:avr:atmegang:cpu=atmega8 + artifact-name-suffix: arduino-avr-atmegang-cpu-atmega8 serial: true softwareserial: false - fqbn: arduino:avr:robotControl + artifact-name-suffix: arduino-avr-robotControl serial: true softwareserial: false - fqbn: arduino:avr:robotMotor + artifact-name-suffix: arduino-avr-robotMotor serial: true softwareserial: false - fqbn: arduino:avr:gemma + artifact-name-suffix: arduino-avr-gemma serial: false softwareserial: false - fqbn: arduino:avr:circuitplay32u4cat + artifact-name-suffix: arduino-avr-circuitplay32u4cat serial: true softwareserial: true - fqbn: arduino:avr:yunmini + artifact-name-suffix: arduino-avr-yunmini serial: true softwareserial: true - fqbn: arduino:avr:chiwawa + artifact-name-suffix: arduino-avr-chiwawa serial: true softwareserial: true - fqbn: arduino:avr:one + artifact-name-suffix: arduino-avr-one serial: true softwareserial: true - fqbn: arduino:avr:unowifi + artifact-name-suffix: arduino-avr-unowifi serial: true softwareserial: true - fqbn: arduino:avr:unomini + artifact-name-suffix: arduino-avr-unomini serial: true softwareserial: true @@ -206,4 +244,4 @@ jobs: with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} - name: ${{ env.SKETCHES_REPORTS_PATH }} + name: sketches-report-${{ matrix.board.artifact-name-suffix }} diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml index 652be5d9d..39e2a0ad2 100644 --- a/.github/workflows/report-size-deltas.yml +++ b/.github/workflows/report-size-deltas.yml @@ -20,5 +20,5 @@ jobs: - name: Comment size deltas reports to PRs uses: arduino/report-size-deltas@v1 with: - # The name of the workflow artifact created by the sketch compilation workflow - sketches-reports-source: sketches-reports + # Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow + sketches-reports-source: ^sketches-report-.+