Disable h/w flow control on UART, set RTS to LOW on init

sandeepmistry · facchinm · commit 4b24b9dcbb35 · 2018-11-27T09:25:54.000+01:00
It’s not supported by the SARA-R410M
diff --git a/variants/mkrnbiot1500/variant.cpp b/variants/mkrnbiot1500/variant.cpp
@@ -233,6 +233,10 @@ void initVariant() {
   // put SARA modem in reset on start to conserve power if it's not used
   pinMode(SARA_RESETN, OUTPUT);
   digitalWrite(SARA_RESETN, HIGH);
+
+  // set RTS to LOW
+  pinMode(SARA_RTS, OUTPUT);
+  digitalWrite(SARA_RTS, LOW);
 }
 
 // Serial1
@@ -244,7 +248,7 @@ void SERCOM5_Handler()
 }
 
 // SerialSARA
-Uart Serial2(&sercom2, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);
+Uart Serial2(&sercom2, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);
 
 void SERCOM2_Handler()
 {
diff --git a/variants/mkrnbiot1500/variant.h b/variants/mkrnbiot1500/variant.h
@@ -162,7 +162,7 @@ extern Uart Serial1;
 extern Uart Serial2;
 #define PIN_SERIAL2_RX (27ul)
 #define PIN_SERIAL2_TX (26ul)
-#define PAD_SERIAL2_TX (UART_TX_RTS_CTS_PAD_0_2_3)
+#define PAD_SERIAL2_TX (UART_TX_PAD_0)
 #define PAD_SERIAL2_RX (SERCOM_RX_PAD_1)
 #define PIN_SERIAL2_RTS (28u)
 #define PIN_SERIAL2_CTS (29u)

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,10 @@ void initVariant() {`
`233`	`233`	`// put SARA modem in reset on start to conserve power if it's not used`
`234`	`234`	`pinMode(SARA_RESETN, OUTPUT);`
`235`	`235`	`digitalWrite(SARA_RESETN, HIGH);`
	`236`	`+`
	`237`	`+ // set RTS to LOW`
	`238`	`+ pinMode(SARA_RTS, OUTPUT);`
	`239`	`+ digitalWrite(SARA_RTS, LOW);`
`236`	`240`	`}`
`237`	`241`
`238`	`242`	`// Serial1`
`@@ -244,7 +248,7 @@ void SERCOM5_Handler()`
`244`	`248`	`}`
`245`	`249`
`246`	`250`	`// SerialSARA`
`247`		`-Uart Serial2(&sercom2, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);`
	`251`	`+Uart Serial2(&sercom2, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);`
`248`	`252`
`249`	`253`	`void SERCOM2_Handler()`
`250`	`254`	`{`