Show ctags errors with verbose compile (#2017)

bouk · web-flow · commit 60a8aa96c725 · 2023-01-31T10:05:13.000+01:00
ctags can fail, for example if TMPDIR is unset. It aids debugging to show the stderr with -v if that's the case
diff --git a/legacy/builder/ctags_runner.go b/legacy/builder/ctags_runner.go
@@ -50,7 +50,7 @@ func (s *CTagsRunner) Run(ctx *types.Context) error {
 	command := exec.Command(parts[0], parts[1:]...)
 	command.Env = append(os.Environ(), ctx.PackageManager.GetEnvVarsForSpawnedProcess()...)
 
-	sourceBytes, _, err := utils.ExecCommand(ctx, command, utils.Capture /* stdout */, utils.Ignore /* stderr */)
+	sourceBytes, _, err := utils.ExecCommand(ctx, command, utils.Capture /* stdout */, utils.ShowIfVerbose /* stderr */)
 	if err != nil {
 		return errors.WithStack(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func (s CTagsRunner) Run(ctx types.Context) error {`
`50`	`50`	`command := exec.Command(parts[0], parts[1:]...)`
`51`	`51`	`command.Env = append(os.Environ(), ctx.PackageManager.GetEnvVarsForSpawnedProcess()...)`
`52`	`52`
`53`		`- sourceBytes, _, err := utils.ExecCommand(ctx, command, utils.Capture /* stdout /, utils.Ignore / stderr */)`
	`53`	`+ sourceBytes, _, err := utils.ExecCommand(ctx, command, utils.Capture /* stdout /, utils.ShowIfVerbose / stderr */)`
`54`	`54`	`if err != nil {`
`55`	`55`	`return errors.WithStack(err)`
`56`	`56`	`}`