Expose the whole created certificate

polldo · polldo · commit e56374881dde · 2022-09-02T13:03:02.000+02:00
diff --git a/command/device/provision.go b/command/device/provision.go
@@ -64,7 +64,7 @@ func downloadProvisioningFile(fqbn string) (string, error) {
 }
 
 type certificateCreator interface {
-	CertificateCreate(id, csr string) (*iotclient.ArduinoCompressedv2, error)
+	CertificateCreate(id, csr string) (*iotclient.ArduinoDevicev2Cert, error)
 }
 
 // provision is responsible for running the provisioning
@@ -129,11 +129,14 @@ func (p provision) configBoard() error {
 	if err != nil {
 		return err
 	}
-	cert, err := p.cert.CertificateCreate(p.id, string(csr))
+
+	c, err := p.cert.CertificateCreate(p.id, string(csr))
 	if err != nil {
 		return err
 	}
 
+	cert := c.Compressed
+
 	logrus.Info("Requesting begin storage")
 	err = p.ser.Send(serial.BeginStorage, nil)
 	if err != nil {
diff --git a/iot/client.go b/iot/client.go
@@ -199,7 +199,7 @@ func (cl *Client) LoraFrequencyPlansList() ([]iotclient.ArduinoLorafreqplanv1, e
 
 // CertificateCreate allows to upload a certificate on Arduino IoT Cloud.
 // It returns the certificate parameters populated by the cloud.
-func (cl *Client) CertificateCreate(id, csr string) (*iotclient.ArduinoCompressedv2, error) {
+func (cl *Client) CertificateCreate(id, csr string) (*iotclient.ArduinoDevicev2Cert, error) {
 	cert := iotclient.CreateDevicesV2CertsPayload{
 		Ca:      "Arduino",
 		Csr:     csr,
@@ -212,7 +212,7 @@ func (cl *Client) CertificateCreate(id, csr string) (*iotclient.ArduinoCompresse
 		return nil, err
 	}
 
-	return &newCert.Compressed, nil
+	return &newCert, nil
 }
 
 // ThingCreate adds a new thing on Arduino IoT Cloud.

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func downloadProvisioningFile(fqbn string) (string, error) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`type certificateCreator interface {`
`67`		`- CertificateCreate(id, csr string) (*iotclient.ArduinoCompressedv2, error)`
	`67`	`+ CertificateCreate(id, csr string) (*iotclient.ArduinoDevicev2Cert, error)`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`// provision is responsible for running the provisioning`
`@@ -129,11 +129,14 @@ func (p provision) configBoard() error {`
`129`	`129`	`if err != nil {`
`130`	`130`	`return err`
`131`	`131`	`}`
`132`		`- cert, err := p.cert.CertificateCreate(p.id, string(csr))`
	`132`	`+`
	`133`	`+ c, err := p.cert.CertificateCreate(p.id, string(csr))`
`133`	`134`	`if err != nil {`
`134`	`135`	`return err`
`135`	`136`	`}`
`136`	`137`
	`138`	`+ cert := c.Compressed`
	`139`	`+`
`137`	`140`	`logrus.Info("Requesting begin storage")`
`138`	`141`	`err = p.ser.Send(serial.BeginStorage, nil)`
`139`	`142`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ func (cl *Client) LoraFrequencyPlansList() ([]iotclient.ArduinoLorafreqplanv1, e`
`199`	`199`
`200`	`200`	`// CertificateCreate allows to upload a certificate on Arduino IoT Cloud.`
`201`	`201`	`// It returns the certificate parameters populated by the cloud.`
`202`		`-func (cl Client) CertificateCreate(id, csr string) (iotclient.ArduinoCompressedv2, error) {`
	`202`	`+func (cl Client) CertificateCreate(id, csr string) (iotclient.ArduinoDevicev2Cert, error) {`
`203`	`203`	`cert := iotclient.CreateDevicesV2CertsPayload{`
`204`	`204`	`Ca: "Arduino",`
`205`	`205`	`Csr: csr,`
`@@ -212,7 +212,7 @@ func (cl Client) CertificateCreate(id, csr string) (iotclient.ArduinoCompresse`
`212`	`212`	`return nil, err`
`213`	`213`	`}`
`214`	`214`
`215`		`- return &newCert.Compressed, nil`
	`215`	`+ return &newCert, nil`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`// ThingCreate adds a new thing on Arduino IoT Cloud.`