fix upload when monitor is open

Alberto Iannaccone · Alberto Iannaccone · commit 1982609c87df · 2022-05-12T15:28:13.000+02:00
diff --git a/arduino-ide-extension/src/common/protocol/monitor-service.ts b/arduino-ide-extension/src/common/protocol/monitor-service.ts
@@ -84,4 +84,7 @@ export namespace Status {
   export const CONFIG_MISSING: ErrorStatus = {
     message: 'Serial Config missing.',
   };
+  export const UPLOAD_IN_PROGRESS: ErrorStatus = {
+    message: 'Upload in progress.',
+  };
 }
diff --git a/arduino-ide-extension/src/node/monitor-manager.ts b/arduino-ide-extension/src/node/monitor-manager.ts
@@ -12,7 +12,7 @@ export const MonitorManagerName = 'monitor-manager';
 export class MonitorManager extends CoreClientAware {
   // Map of monitor services that manage the running pluggable monitors.
   // Each service handles the lifetime of one, and only one, monitor.
-  // If either the board or port managed changes a new service must
+  // If either the board or port managed changes, a new service must
   // be started.
   private monitorServices = new Map<MonitorID, MonitorService>();
 
@@ -109,6 +109,7 @@ export class MonitorManager extends CoreClientAware {
       // There's no monitor running there, bail
       return;
     }
+    monitor.setUploadInProgress(true);
     return await monitor.pause();
   }
 
@@ -132,6 +133,7 @@ export class MonitorManager extends CoreClientAware {
       // There's no monitor running there, bail
       return Status.NOT_CONNECTED;
     }
+    monitor.setUploadInProgress(false);
     return await monitor.start();
   }
 
diff --git a/arduino-ide-extension/src/node/monitor-service.ts b/arduino-ide-extension/src/node/monitor-service.ts
@@ -53,6 +53,8 @@ export class MonitorService extends CoreClientAware implements Disposable {
   protected readonly webSocketProvider: WebSocketProvider =
     new WebSocketProviderImpl();
 
+  protected uploadInProgress = false;
+
   constructor(
     @inject(ILogger)
     @named(MonitorServiceName)
@@ -80,6 +82,10 @@ export class MonitorService extends CoreClientAware implements Disposable {
     );
   }
 
+  setUploadInProgress(status: boolean): void {
+    this.uploadInProgress = status;
+  }
+
   getWebsocketAddressPort(): number {
     return this.webSocketProvider.getAddress().port;
   }
@@ -113,11 +119,14 @@ export class MonitorService extends CoreClientAware implements Disposable {
       return Status.CONFIG_MISSING;
     }
 
+    if (this.uploadInProgress) {
+      return Status.UPLOAD_IN_PROGRESS;
+    }
+
     this.logger.info('starting monitor');
     await this.coreClientProvider.initialized;
     const coreClient = await this.coreClient();
     const { client, instance } = coreClient;
-
     this.duplex = client.monitor();
     this.duplex
       .on('close', () => {
@@ -205,7 +214,7 @@ export class MonitorService extends CoreClientAware implements Disposable {
    * Pauses the currently running monitor, it still closes the gRPC connection
    * with the underlying monitor process but it doesn't stop the message handlers
    * currently running.
-   * This is mainly used to handle upload when to the board/port combination
+   * This is mainly used to handle upload with the board/port combination
    * the monitor is listening to.
    * @returns
    */
@@ -223,7 +232,8 @@ export class MonitorService extends CoreClientAware implements Disposable {
       this.logger.info(
         `stopped monitor to ${this.port?.address} using ${this.port?.protocol}`
       );
-      resolve();
+
+      this.duplex.on('end', resolve);
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -84,4 +84,7 @@ export namespace Status {`
`84`	`84`	`export const CONFIG_MISSING: ErrorStatus = {`
`85`	`85`	`message: 'Serial Config missing.',`
`86`	`86`	`};`
	`87`	`+ export const UPLOAD_IN_PROGRESS: ErrorStatus = {`
	`88`	`+ message: 'Upload in progress.',`
	`89`	`+ };`
`87`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ export const MonitorManagerName = 'monitor-manager';`
`12`	`12`	`export class MonitorManager extends CoreClientAware {`
`13`	`13`	`// Map of monitor services that manage the running pluggable monitors.`
`14`	`14`	`// Each service handles the lifetime of one, and only one, monitor.`
`15`		`- // If either the board or port managed changes a new service must`
	`15`	`+ // If either the board or port managed changes, a new service must`
`16`	`16`	`// be started.`
`17`	`17`	`private monitorServices = new Map<MonitorID, MonitorService>();`
`18`	`18`
`@@ -109,6 +109,7 @@ export class MonitorManager extends CoreClientAware {`
`109`	`109`	`// There's no monitor running there, bail`
`110`	`110`	`return;`
`111`	`111`	`}`
	`112`	`+ monitor.setUploadInProgress(true);`
`112`	`113`	`return await monitor.pause();`
`113`	`114`	`}`
`114`	`115`
`@@ -132,6 +133,7 @@ export class MonitorManager extends CoreClientAware {`
`132`	`133`	`// There's no monitor running there, bail`
`133`	`134`	`return Status.NOT_CONNECTED;`
`134`	`135`	`}`
	`136`	`+ monitor.setUploadInProgress(false);`
`135`	`137`	`return await monitor.start();`
`136`	`138`	`}`
`137`	`139`