Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-ide
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.0.0-beta.10
Choose a base ref
...
head repository: arduino/arduino-ide
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.0.0-beta.11
Choose a head ref
  • 13 commits
  • 45 files changed
  • 5 contributors

Commits on Aug 6, 2021

  1. Update BUILDING.md

    Corrected typographical error where "on" was used rather than "one".
    Jmarinis authored and per1234 committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    167f059 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Use standardized name for certificate check workflow

    This is the naming convention established in the standardized "template" workflow.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    92af4be View commit details
    Browse the repository at this point in the history
  2. Add API trigger to "Check Certificates" workflow

    The `repository_dispatch` event allows triggering workflows via the GitHub API. This might be useful for triggering an
    immediate check in multiple relevant repositories after an external change, or some automated process. Although we don't
    have any specific need for this event at the moment, the event has no impact on the workflow, so there is no reason
    against having it. It is the sort of thing that can end up being useful if it is already in consistently in place, but
    not worth setting up on demand, since the effort to set it up is greater than the effort to trigger all the workflows
    manually.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b9c777a View commit details
    Browse the repository at this point in the history
  3. Run "Check Certificates" workflow on modification

    This will facilitate testing and review of modifications to the workflow.
    
    Because the workflow requires access to repository secrets, and so will fail whenever triggered by an event from a fork,
    a conditional is added to make it only run when the modifications are made within the `arduino/arduino-ide`
    repository.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    289f07f View commit details
    Browse the repository at this point in the history
  4. Make trivial adjustments to comments in "Check Certificates" workflow

    No functional difference, and neither is necessarily superior, but this is how it is in the "template", and so it must be
    here as well.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b84b6c9 View commit details
    Browse the repository at this point in the history
  5. Use the matrix identifier to name the "Check Certificates" workflow jobs

    When no name is provided for a matrix job, the workflow job is named according to the contents of
    `jobs[].<job_id>.strategy.matrix[]`. That can result in some fairly cryptic job names when the matrix contains a complex
    data structure as is the case here. We already have a string to uniquely identify each certificate to humans, which is
    exactly what the `jobs[].<job_id>.name` property does for jobs, so it will be an improvement to name the jobs according
    to that identifier.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4b36852 View commit details
    Browse the repository at this point in the history
  6. Make trivial formatting changes to "Check Certificates" workflow

    No functional change, and neither is necessarily superior, but this is the formatting style either defined in the
    "template", or by the repository's Prettier formatting configuration preferences, so it must be brought into compliance
    here as well.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    735d373 View commit details
    Browse the repository at this point in the history
  7. Use standardized repository secret name for Slack webhook

    The "Check Certificates" workflow is configured to send a notification via Slack if a problem is found with a certificate.
    TThis is currently posted to the `team_tooling` channel, but that is not necessarily always going to be the case, and for
    every deployment of the workflow. So a less specific secret name is more universally applicable to serve all applications
    of this "template" workflow.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    302f010 View commit details
    Browse the repository at this point in the history
  8. Use major version ref of Slack notification action

    At the time the workflow was written the authors of the `rtCamp/action-slack-notify` GitHub Actions action did not
    provide a major version ref. This meant that it was necessary to pin the action to a specific version.
    
    Since then, a few new releases have been made, meaning an outdated version of the action was in use as a consequence of
    the pinning.
    
    The action now offers a `v2` major ref. Use of this ref will cause the workflow to benefit from ongoing development to
    the action up until such time as a new major release is made, at which time we would need to evaluate whether any changes
    to the workflow are required by the breaking change that triggered the major release before updating the major ref
    (e.g., `uses: rtCamp/action-slack-notify@v3`).
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    bed6e0b View commit details
    Browse the repository at this point in the history
  9. Add source URL comment to "Check Certificates" workflow

    This will make it easier for the maintainers to sync fixes and improvements in either direction between the upstream
    "template" workflow and its installation in this repository.
    per1234 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    2cb9889 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. [ATL-493] Support platforms installed in directories.user

    Alberto Iannaccone authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    6233e1f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. [ATL-1533] Firmware&Certificate Uploader (#469)

    Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
    fstasi and Alberto Iannaccone authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    302fb7b View commit details
    Browse the repository at this point in the history
  2. Updated to 2.0.0-beta.11

    fstasi committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    7d5381b View commit details
    Browse the repository at this point in the history
Loading