-
-
Notifications
You must be signed in to change notification settings - Fork 448
Comparing changes
Open a pull request
base repository: arduino/arduino-ide
base: 2.0.0-beta.10
head repository: arduino/arduino-ide
compare: 2.0.0-beta.11
- 13 commits
- 45 files changed
- 5 contributors
Commits on Aug 6, 2021
-
Corrected typographical error where "on" was used rather than "one".
Configuration menu - View commit details
-
Copy full SHA for 167f059 - Browse repository at this point
Copy the full SHA 167f059View commit details
Commits on Aug 18, 2021
-
Use standardized name for certificate check workflow
This is the naming convention established in the standardized "template" workflow.
Configuration menu - View commit details
-
Copy full SHA for 92af4be - Browse repository at this point
Copy the full SHA 92af4beView commit details -
Add API trigger to "Check Certificates" workflow
The `repository_dispatch` event allows triggering workflows via the GitHub API. This might be useful for triggering an immediate check in multiple relevant repositories after an external change, or some automated process. Although we don't have any specific need for this event at the moment, the event has no impact on the workflow, so there is no reason against having it. It is the sort of thing that can end up being useful if it is already in consistently in place, but not worth setting up on demand, since the effort to set it up is greater than the effort to trigger all the workflows manually.
Configuration menu - View commit details
-
Copy full SHA for b9c777a - Browse repository at this point
Copy the full SHA b9c777aView commit details -
Run "Check Certificates" workflow on modification
This will facilitate testing and review of modifications to the workflow. Because the workflow requires access to repository secrets, and so will fail whenever triggered by an event from a fork, a conditional is added to make it only run when the modifications are made within the `arduino/arduino-ide` repository.
Configuration menu - View commit details
-
Copy full SHA for 289f07f - Browse repository at this point
Copy the full SHA 289f07fView commit details -
Make trivial adjustments to comments in "Check Certificates" workflow
No functional difference, and neither is necessarily superior, but this is how it is in the "template", and so it must be here as well.
Configuration menu - View commit details
-
Copy full SHA for b84b6c9 - Browse repository at this point
Copy the full SHA b84b6c9View commit details -
Use the matrix identifier to name the "Check Certificates" workflow jobs
When no name is provided for a matrix job, the workflow job is named according to the contents of `jobs[].<job_id>.strategy.matrix[]`. That can result in some fairly cryptic job names when the matrix contains a complex data structure as is the case here. We already have a string to uniquely identify each certificate to humans, which is exactly what the `jobs[].<job_id>.name` property does for jobs, so it will be an improvement to name the jobs according to that identifier.
Configuration menu - View commit details
-
Copy full SHA for 4b36852 - Browse repository at this point
Copy the full SHA 4b36852View commit details -
Make trivial formatting changes to "Check Certificates" workflow
No functional change, and neither is necessarily superior, but this is the formatting style either defined in the "template", or by the repository's Prettier formatting configuration preferences, so it must be brought into compliance here as well.
Configuration menu - View commit details
-
Copy full SHA for 735d373 - Browse repository at this point
Copy the full SHA 735d373View commit details -
Use standardized repository secret name for Slack webhook
The "Check Certificates" workflow is configured to send a notification via Slack if a problem is found with a certificate. TThis is currently posted to the `team_tooling` channel, but that is not necessarily always going to be the case, and for every deployment of the workflow. So a less specific secret name is more universally applicable to serve all applications of this "template" workflow.
Configuration menu - View commit details
-
Copy full SHA for 302f010 - Browse repository at this point
Copy the full SHA 302f010View commit details -
Use major version ref of Slack notification action
At the time the workflow was written the authors of the `rtCamp/action-slack-notify` GitHub Actions action did not provide a major version ref. This meant that it was necessary to pin the action to a specific version. Since then, a few new releases have been made, meaning an outdated version of the action was in use as a consequence of the pinning. The action now offers a `v2` major ref. Use of this ref will cause the workflow to benefit from ongoing development to the action up until such time as a new major release is made, at which time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before updating the major ref (e.g., `uses: rtCamp/action-slack-notify@v3`).
Configuration menu - View commit details
-
Copy full SHA for bed6e0b - Browse repository at this point
Copy the full SHA bed6e0bView commit details -
Add source URL comment to "Check Certificates" workflow
This will make it easier for the maintainers to sync fixes and improvements in either direction between the upstream "template" workflow and its installation in this repository.
Configuration menu - View commit details
-
Copy full SHA for 2cb9889 - Browse repository at this point
Copy the full SHA 2cb9889View commit details
Commits on Aug 23, 2021
-
[ATL-493] Support platforms installed in directories.user
Alberto Iannaccone authoredAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 6233e1f - Browse repository at this point
Copy the full SHA 6233e1fView commit details
Commits on Aug 25, 2021
-
[ATL-1533] Firmware&Certificate Uploader (#469)
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
Configuration menu - View commit details
-
Copy full SHA for 302fb7b - Browse repository at this point
Copy the full SHA 302fb7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d5381b - Browse repository at this point
Copy the full SHA 7d5381bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.0.0-beta.10...2.0.0-beta.11