Skip to content

Move settings access to File > Preferences #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
per1234 opened this issue Feb 12, 2021 · 4 comments · Fixed by #209
Closed

Move settings access to File > Preferences #15

per1234 opened this issue Feb 12, 2021 · 4 comments · Fixed by #209
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Feb 12, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
A pretty gear icon is shown prominently in the side bar:
Clipboard02
When this is clicked, the very complex "Preferences" tab opens. This exposes options that will be of no use to the target user. The settings available via File > Preferences are the only thing the target user needs. It is good to give more advanced users access to advanced configuration options (as is done in the Java IDE's File > Preferences > More preferences can be edited directly in the file... but the current UI funnels all users equally to those advanced preferences.

Describe the solution you'd like
Make the gear icon in the side bar open the File > Preferences dialog. Provide some form of access (even if it's only mentioning editing the settings.json file directly) to the advanced configuration from File > Preferences.

Describe alternatives you've considered
Remove the gear icon from the side bar. Preferences are accessed only via File > Preferences.

Environment

OS: Windows 10
Version: 2.0.0-beta.2-snapshot.298cc11
Date: 2021-02-15T14:16:52.603Z
CLI Version: 0.16.0 alpha [c977a238]
@per1234 per1234 added the type: enhancement Proposed improvement label Feb 12, 2021
@ubidefeo
Copy link

that is an elusive little UI element
I think it should be removed

@kittaakos
Copy link
Contributor

It comes from Theia. I will remove it.

Unfortunately, the same can happen all the time when we update to a newer version of Theia. We might bring new, undesired features to the app.

@ubidefeo
Copy link

ubidefeo commented Mar 4, 2021

@kittaakos can we move it to a button/link inside the compact preferences GUI?
For now I kinda like having some advanced/unsupported way of customising the IDE for that one user over 500 who wants to achieve that particular goal.

Also the "preferences" pop-over loses alignment with the gear icon when UI is zoomed.
Must be some local-to-global mapping gone awry :)

Screenshot 2021-03-04 at 11 52 58

Screenshot 2021-03-04 at 11 53 04

Screenshot 2021-03-04 at 11 53 22

@kittaakos
Copy link
Contributor

kittaakos commented Mar 4, 2021 •
edited
Loading

can we move it to a button/link inside the compact preferences GUI?

Sure.

Or we can just remove it. I would expect, advanced users can use the Command Palette (with F1 or Ctrl/⌘+Shift+P) and open it if you they want to.

Screen Shot 2021-03-04 at 12 08 48

screencast.2021-03-04.12-10-33.mp4

Also the "preferences" pop-over loses alignment with the gear icon when UI is zoomed.

It's a known issue and has been fixed upstream: eclipse-theia/theia#9082

@fstasi fstasi mentioned this issue Mar 15, 2021
Merged
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ATL-959] Remove settings icon from sidebar arduino/arduino-ide
3 participants
@kittaakos @ubidefeo @per1234