Skip to content

Incorrect dialog when library dependency already installed #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
per1234 opened this issue Dec 26, 2021 · 3 comments
Open
3 tasks done

Incorrect dialog when library dependency already installed #721

per1234 opened this issue Dec 26, 2021 · 3 comments
Assignees
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 26, 2021

Describe the problem

Arduino library authors may specify library dependencies in the depends field of the library.properties metadata file. When using Library Manager to install a library that specifies dependencies which are not already installed, the user is offered the installation of the dependencies.

🐛 This dialog is currently presented even when the dependencies are already installed.

To reproduce

  1. Use Library Manager to install the "ArduinoRS485" library.
  2. Use Library Manager to install the "ArduinoModbus" library.
    (this library specifies a dependency on the "ArduinoRS485" library)
    🐛 A dialog appears which erroneously claims:

    The library ArduinoModbus:1.0.6 needs another dependency currently not installed:

        - ArduinoRS485

    Would you like to install the missing dependency?

image

Expected behavior

Dependencies installation dialog only appears when dependencies are not already installed.

Arduino IDE version

Original report

2.0.0-rc3

Last verified with

9a6a457

Operating system

Windows

Operating system version

11

Additional context

The issue occurs even after a restart, so it is not specific to the dependency being installed in the same session as the dependent library, as was done in the demo for the sake of simplicity.

Additional reports

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 26, 2021
@ubidefeo
Copy link

@per1234
does IDE 1.8.x ignore the ones already installed?

@per1234
Copy link
Contributor Author

per1234 commented Feb 16, 2022

does IDE 1.8.x ignore the ones already installed?

Correct. Arduino IDE 1.x only offers to install the dependencies that are not already installed.

That includes the situation where a library has multiple dependencies, some of which are installed, and others not installed. In this case, it will show the dialog, but only list the ones that are not already installed.

@ropg
Copy link

ropg commented Jan 12, 2025

Given that it's been over 3 years, this should maybe be closed with "Won't fix". but that seems silly given that it's quite confusing to users of all libraries with dependencies and that it's such a glaringly wrong UI-thing to happen.

Alternatively to fixing the logic, one could change the sentence on the dialog to something like:

The library XXXX needs other library/libraries:

YYY
ZZZ

To install these libraries if they are not installed yet, select "Install All".

I do C/C++, Python, Lua, Javascript/Typescript (and PHP if you really force me) but I'm not into Java, so I apologize I can't help further by fixing it myself...

@per1234 per1234 marked this as a duplicate of #2655 Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

4 participants